diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-03-09 20:08:15 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-08-02 04:48:20 +0000 |
| commit | 21e609c1c92c47bd8990c2ce25adf5987b5dd1b2 (patch) | |
| tree | 62f5cb8577d9e62fc44cd8da69ac396230ab1e8c /src/northbridge/amd/agesa/family14/state_machine.c | |
| parent | ed8d2777f8c363d40abe51576a285a6fecf7ee3e (diff) | |
| download | coreboot-21e609c1c92c47bd8990c2ce25adf5987b5dd1b2.tar.gz coreboot-21e609c1c92c47bd8990c2ce25adf5987b5dd1b2.tar.bz2 coreboot-21e609c1c92c47bd8990c2ce25adf5987b5dd1b2.zip | |
AGESA: Move romstage-ramstage splitline
In AGESA specification AmdInitEnv() is to be called once
host memory allocator has started. In coreboot context this
could mean either availability of CBMEM or malloc heap.
As for AmdS3LateRestore(), there is no requirement to have
it run as part of the romstage either.
Change-Id: Icc8d97b82df89e2480e601d5c2e094de0365b0a5
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/18888
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/northbridge/amd/agesa/family14/state_machine.c')
| -rw-r--r-- | src/northbridge/amd/agesa/family14/state_machine.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/northbridge/amd/agesa/family14/state_machine.c b/src/northbridge/amd/agesa/family14/state_machine.c index fbc2d7e1e551..3280180f8caa 100644 --- a/src/northbridge/amd/agesa/family14/state_machine.c +++ b/src/northbridge/amd/agesa/family14/state_machine.c @@ -57,7 +57,7 @@ void platform_AfterInitEnv(struct sysinfo *cb, AMD_ENV_PARAMS *Env) { amd_initenv(); #if 0 - /* FIXME: It's only in ramstage. */ + /* FIXME: Should move the callsite from cimx/sb800 to here. */ sb_Before_Pci_Init(); #endif } @@ -69,10 +69,7 @@ void platform_BeforeS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) void platform_AfterS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) { -#if 0 - /* FIXME: It's only in ramstage. */ sb_Before_Pci_Restore_Init(); -#endif } void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) |