diff options
| author | Julius Werner <jwerner@chromium.org> | 2021-04-02 17:24:34 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-04-06 07:49:43 +0000 |
| commit | 5a090bf1257b6a5464ac21527d350b4aa13097ab (patch) | |
| tree | d398bd1e7a548999d709175cfefef301aef953d7 /src/security | |
| parent | 6296ca8ad9137a12094ad5d49d6f937dcf502105 (diff) | |
| download | coreboot-5a090bf1257b6a5464ac21527d350b4aa13097ab.tar.gz coreboot-5a090bf1257b6a5464ac21527d350b4aa13097ab.tar.bz2 coreboot-5a090bf1257b6a5464ac21527d350b4aa13097ab.zip | |
verstage: Add debug print when returning from verstage
RETURN_FROM_VERSTAGE is a somewhat tricky construct that we don't
normally do otherwise in coreboot. While it works remarkably well in
general, new development can lead to unintentional interactions with
confusing results. This patch adds a debug print to the verstage right
before returning to the bootblock so that it's obvious this happens,
because otherwise in some cases the last printout in the verstage is
about some TPM commands which can be misleading when execution hangs
after that point.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I9ca68a32d7a50c95d9a6948d35816fee583611bc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52086
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/security')
| -rw-r--r-- | src/security/vboot/verstage.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/security/vboot/verstage.c b/src/security/vboot/verstage.c index d2a970554660..d785e0e6ac54 100644 --- a/src/security/vboot/verstage.c +++ b/src/security/vboot/verstage.c @@ -19,6 +19,7 @@ void main(void) if (CONFIG(VBOOT_RETURN_FROM_VERSTAGE)) { verstage_main(); + printk(BIOS_DEBUG, "VBOOT: Returning from verstage.\n"); } else { run_romstage(); hlt(); |