diff options
| author | Derek Huang <derekhuang@google.com> | 2022-12-15 07:27:41 +0000 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2023-01-10 09:33:47 +0000 |
| commit | da3812208ea24f9438b7631374d22fc3ccee14bd (patch) | |
| tree | cbeca7f258d412fc6c8b18a0928475ecea38282a /src/security | |
| parent | b3ebf5ba0b8113b67fcf0e0c884abd1494acc20b (diff) | |
| download | coreboot-da3812208ea24f9438b7631374d22fc3ccee14bd.tar.gz coreboot-da3812208ea24f9438b7631374d22fc3ccee14bd.tar.bz2 coreboot-da3812208ea24f9438b7631374d22fc3ccee14bd.zip | |
chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
When AP boots up after Cr50 firmware update and reboot, AP finds
that Cr50 reset is required for Cr50 to pick the new firmware so
it trigger Cr50 reset and power off the system, AP expects system
will power on automatically after Cr50 reset. However this is not
the case for Chromebox, Chromebox EC set AP_IDLE flag when system
is shutting down, when AP_IDLE flag is set in EC, the system stays
at S5/G3 and wait for power button presssend. It cause an issue in
factory that the operator needs to press power button to power on
the DUT after Cr50 firmware update.
This patch sends EC command to direct EC to clear AP_IDLE flag
after AP shutdown so AP can boot up when Cr50 reset.
BUG=b:261119366
BRANCH=firmware-brya-14505.B
TEST=DUT boots up after Cr50 firmware update in factory test flow
Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Signed-off-by: Derek Huang <derekhuang@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70773
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/security')
| -rw-r--r-- | src/security/tpm/tss/vendor/cr50/Kconfig | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/security/tpm/tss/vendor/cr50/Kconfig b/src/security/tpm/tss/vendor/cr50/Kconfig index 33a5cf3da17f..6aa1b10550b7 100644 --- a/src/security/tpm/tss/vendor/cr50/Kconfig +++ b/src/security/tpm/tss/vendor/cr50/Kconfig @@ -40,4 +40,11 @@ config GOOGLE_TPM_IRQ_TIMEOUT_MS using Cr50 in order to support legacy pre-ready-IRQ cr50 factory images. Default to 750ms otherwise. +config CR50_RESET_CLEAR_EC_AP_IDLE_FLAG + def_bool n + help + Select this if the variant is a Chromebox/base. This allows AP to direct EC + to clear AP_IDLE flag after AP shutdown before triggering CR50 reset and + shutting down AP so that AP can boot up after CR50 reset. + endif |