diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-03-02 23:36:55 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-03-03 22:45:41 +0000 |
| commit | af17f0b7ce06f98586d31d1a2a50fb4fbc9cffd7 (patch) | |
| tree | 880a111c7846288ecde83be3b9fea65d3cb4705a /src/soc/amd/cezanne | |
| parent | b1197af7f5aa18b17160f0c5fba9869482891cd2 (diff) | |
| download | coreboot-af17f0b7ce06f98586d31d1a2a50fb4fbc9cffd7.tar.gz coreboot-af17f0b7ce06f98586d31d1a2a50fb4fbc9cffd7.tar.bz2 coreboot-af17f0b7ce06f98586d31d1a2a50fb4fbc9cffd7.zip | |
soc/amd/*/northbridge,root_complex: add comment about PCI BARs
Add a comment to point out that the read_resources functions aren't
missing a pci_dev_read_resources call that would add the resources for
the BARs of the PC device.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie480832e0d7954135d2171dda986e477ef7b6c09
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62547
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/soc/amd/cezanne')
| -rw-r--r-- | src/soc/amd/cezanne/root_complex.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/soc/amd/cezanne/root_complex.c b/src/soc/amd/cezanne/root_complex.c index dabfa789aa06..9cb668e04d77 100644 --- a/src/soc/amd/cezanne/root_complex.c +++ b/src/soc/amd/cezanne/root_complex.c @@ -114,6 +114,9 @@ static void read_resources(struct device *dev) early_reserved_dram_start = e->base; early_reserved_dram_end = e->base + e->size; + /* The root complex has no PCI BARs implemented, so there's no need to call + pci_dev_read_resources for it */ + /* 0x0 - 0x9ffff */ ram_resource(dev, idx++, 0, 0xa0000 / KiB); |