diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-05-05 15:19:03 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-05-06 14:37:25 +0000 |
| commit | 00ec1b9fc7baf8bbf3eb506225274e519c16e4fe (patch) | |
| tree | bb6bb1d4295af774b6c22e201cbd6faa94d9f855 /src/soc/amd/common | |
| parent | d8d522884bfbc2b5239a9ece77ab074c846167bd (diff) | |
| download | coreboot-00ec1b9fc7baf8bbf3eb506225274e519c16e4fe.tar.gz coreboot-00ec1b9fc7baf8bbf3eb506225274e519c16e4fe.tar.bz2 coreboot-00ec1b9fc7baf8bbf3eb506225274e519c16e4fe.zip | |
soc/amd/common/block/psp/psp_gen2: simplify soc_read_c2p38
Commit 198cc26e4951b3dbca588286706b7df562c45d42 (soc/amd/common/block/
psp/psp_gen2: use SMN access to PSP) changed how the PSP registers are
accessed. Since the new method doesn't need to rely on a MMIO base
address to be configured, the read will always be successful and so
soc_read_c2p38 doesn't need to return an error status and can directly
return the value instead.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I1abace04668947ba3223a107461a27dddc0a9d83
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64078
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: ritul guru <ritul.bits@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/soc/amd/common')
| -rw-r--r-- | src/soc/amd/common/block/psp/psp_def.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/common/block/psp/psp_gen2.c | 13 |
2 files changed, 4 insertions, 11 deletions
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index 4d860ff276d0..d1a06fbce8f5 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -86,6 +86,6 @@ void psp_print_cmd_status(int cmd_status, struct mbox_buffer_header *header); /* This command needs to be implemented by the generation specific code. */ int send_psp_command(u32 command, void *buffer); -enum cb_err soc_read_c2p38(uint32_t *msg_38_value); +uint32_t soc_read_c2p38(void); #endif /* __AMD_PSP_DEF_H__ */ diff --git a/src/soc/amd/common/block/psp/psp_gen2.c b/src/soc/amd/common/block/psp/psp_gen2.c index 820d44d4c979..208a9bfca476 100644 --- a/src/soc/amd/common/block/psp/psp_gen2.c +++ b/src/soc/amd/common/block/psp/psp_gen2.c @@ -111,10 +111,9 @@ int send_psp_command(u32 command, void *buffer) return 0; } -enum cb_err soc_read_c2p38(uint32_t *msg_38_value) +uint32_t soc_read_c2p38(void) { - *msg_38_value = smn_read32(SMN_PSP_PUBLIC_BASE + CORE_2_PSP_MSG_38_OFFSET); - return CB_SUCCESS; + return smn_read32(SMN_PSP_PUBLIC_BASE + CORE_2_PSP_MSG_38_OFFSET); } static void psp_set_spl_fuse(void *unused) @@ -122,7 +121,6 @@ static void psp_set_spl_fuse(void *unused) if (!CONFIG(SOC_AMD_COMMON_BLOCK_PSP_FUSE_SPL)) return; - uint32_t msg_38_value = 0; int cmd_status = 0; struct mbox_cmd_late_spl_buffer buffer = { .header = { @@ -130,12 +128,7 @@ static void psp_set_spl_fuse(void *unused) } }; - if (soc_read_c2p38(&msg_38_value) != CB_SUCCESS) { - printk(BIOS_ERR, "PSP: Failed to read psp base address.\n"); - return; - } - - if (msg_38_value & CORE_2_PSP_MSG_38_FUSE_SPL) { + if (soc_read_c2p38() & CORE_2_PSP_MSG_38_FUSE_SPL) { printk(BIOS_DEBUG, "PSP: Fuse SPL requested\n"); cmd_status = send_psp_command(MBOX_BIOS_CMD_SET_SPL_FUSE, &buffer); psp_print_cmd_status(cmd_status, NULL); |