summaryrefslogtreecommitdiffstats
path: root/src/soc/amd/common
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-03-30 22:47:00 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-04-01 14:31:05 +0000
commitb4e3408967a61c425ae27690af2fc23a79a94816 (patch)
treed13e839a7e2ce92f34057b1018f0a27a4d989f83 /src/soc/amd/common
parent02512eeb2ee5e0cea75dbd4f91501c998e93cc45 (diff)
downloadcoreboot-b4e3408967a61c425ae27690af2fc23a79a94816.tar.gz
coreboot-b4e3408967a61c425ae27690af2fc23a79a94816.tar.bz2
coreboot-b4e3408967a61c425ae27690af2fc23a79a94816.zip
soc/amd/common/block/i2c/i23c_pad_ctrl: invert and mask
When masking out bits with an and mask, the bit mask needs to be inverted. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I9739d7150e230fbbe6523413de9c07d7340f3c61 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63222 Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common')
-rw-r--r--src/soc/amd/common/block/i2c/i23c_pad_ctrl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
index 36211a32641d..243905417e1e 100644
--- a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
+++ b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c
@@ -48,7 +48,7 @@ void fch_i23c_pad_init(unsigned int bus,
pad_ctrl |= speed == I2C_SPEED_STANDARD ?
I23C_PAD_CTRL_FALLSLEW_SEL_STD : I23C_PAD_CTRL_FALLSLEW_SEL_LOW;
- pad_ctrl &= I23C_PAD_CTRL_SLEW_N_MASK;
+ pad_ctrl &= ~I23C_PAD_CTRL_SLEW_N_MASK;
pad_ctrl |= I23C_PAD_CTRL_SLEW_N_FAST;
misc_write32(MISC_I23C_PAD_CTRL(bus), pad_ctrl);