summaryrefslogtreecommitdiffstats
path: root/src/soc/amd/glinda/include
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-07-06 16:36:41 +0200
committerFelix Held <felix-coreboot@felixheld.de>2023-07-07 14:49:42 +0000
commitf3180f07b55dfe29938d2883d9a98a529fe9ef1a (patch)
tree5e00db3f1984230eee05d8f76fc33474f5520efe /src/soc/amd/glinda/include
parent8f4b015759cf6189d8f942d7c06bea6a42a06c54 (diff)
downloadcoreboot-f3180f07b55dfe29938d2883d9a98a529fe9ef1a.tar.gz
coreboot-f3180f07b55dfe29938d2883d9a98a529fe9ef1a.tar.bz2
coreboot-f3180f07b55dfe29938d2883d9a98a529fe9ef1a.zip
soc/amd/*/globalnvs,nvs: remove deprecated & unused CBMC field from GNVS
Commit cde4f3b2790d ("acpi/gnvs.c: Drop unused pointer to the cbmem console") removed writing the coreboot memory console pointer to the GNVS and kept the CBMC field as reserved. Since those fields aren't needed any more and there are no dependencies on the absolute position of the different fields in GNVS as long as both GNVS definitions on the C and the ASL side match, remove the deprecated and unused CBMC field from the GNVS structs. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Iadfaf5a4ec1401b027dbfb6a7c6ce74a1dcecdfa Reviewed-on: https://review.coreboot.org/c/coreboot/+/76351 Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/soc/amd/glinda/include')
-rw-r--r--src/soc/amd/glinda/include/soc/nvs.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/soc/amd/glinda/include/soc/nvs.h b/src/soc/amd/glinda/include/soc/nvs.h
index 2b1d17bce876..efe5dded874a 100644
--- a/src/soc/amd/glinda/include/soc/nvs.h
+++ b/src/soc/amd/glinda/include/soc/nvs.h
@@ -13,9 +13,8 @@
struct __packed global_nvs {
/* Miscellaneous */
- uint32_t unused_was_cbmc; /* 0x00 - 0x03 - coreboot Memory Console */
- uint64_t pm1i; /* 0x04 - 0x0b - System Wake Source - PM1 Index */
- uint64_t gpei; /* 0x0c - 0x13 - GPE Wake Source */
+ uint64_t pm1i; /* 0x00 - 0x07 - System Wake Source - PM1 Index */
+ uint64_t gpei; /* 0x08 - 0x0f - GPE Wake Source */
};
#endif /* AMD_GLINDA_NVS_H */