summaryrefslogtreecommitdiffstats
path: root/src/soc/amd/picasso/mca.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2021-07-09 23:04:27 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-07-12 15:29:13 +0000
commit4add9923c0cdc07ddfa554720d651f54aa2d2f2e (patch)
treee7aa5f9bedcd20fdaa5475591056f6aaf04f721e /src/soc/amd/picasso/mca.c
parentf48eecbbe0867b0f592c8b4e18907f8bf99f1c5e (diff)
downloadcoreboot-4add9923c0cdc07ddfa554720d651f54aa2d2f2e.tar.gz
coreboot-4add9923c0cdc07ddfa554720d651f54aa2d2f2e.tar.bz2
coreboot-4add9923c0cdc07ddfa554720d651f54aa2d2f2e.zip
soc/amd/*/mca: use mca_get_bank_count()
Use the common mca_get_bank_count function instead of open-coding the functionality to get the MCA bank number. Also re-type the num_banks variable from signed in to unsigned int, since the number of MCA bank is always positive. Change-Id: I126767cf9ad468cab6d6537dd73e9b2dc377b5c4 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56185 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/soc/amd/picasso/mca.c')
-rw-r--r--src/soc/amd/picasso/mca.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c
index 12d4cccbc8ec..acb248d2f491 100644
--- a/src/soc/amd/picasso/mca.c
+++ b/src/soc/amd/picasso/mca.c
@@ -152,12 +152,10 @@ static const char *const mca_bank_name[] = {
void check_mca(void)
{
int i;
- msr_t cap;
struct mca_bank mci;
- int num_banks;
+ unsigned int num_banks;
- cap = rdmsr(IA32_MCG_CAP);
- num_banks = cap.lo & MCA_BANKS_MASK;
+ num_banks = mca_get_bank_count();
for (i = 0 ; i < num_banks ; i++) {
mci.sts = rdmsr(MCAX_STATUS_MSR(i));