summaryrefslogtreecommitdiffstats
path: root/src/soc/amd/picasso/mca.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2021-07-12 21:53:23 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-07-14 02:22:30 +0000
commit82af7491c267bfd74c6c3c4f63fe091b10814fb1 (patch)
tree94f692712044671e33e072ca1b73ed00252ffefd /src/soc/amd/picasso/mca.c
parent5183abd3123586d8daed9f0878cbc521b74c46ff (diff)
downloadcoreboot-82af7491c267bfd74c6c3c4f63fe091b10814fb1.tar.gz
coreboot-82af7491c267bfd74c6c3c4f63fe091b10814fb1.tar.bz2
coreboot-82af7491c267bfd74c6c3c4f63fe091b10814fb1.zip
soc/amd/picasso,stoneyridge/mca: use unsigned int for MCA bank number
Change-Id: Ib31075fd615eaa8492ce0179b3b21317554f1c80 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56238 Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/picasso/mca.c')
-rw-r--r--src/soc/amd/picasso/mca.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c
index 84f3eadfd727..07e700ee2473 100644
--- a/src/soc/amd/picasso/mca.c
+++ b/src/soc/amd/picasso/mca.c
@@ -14,7 +14,7 @@
#define MCAX_USED_REGISTERS_PER_BANK (MCAX_MISC4_OFFSET + 1)
struct mca_bank_status {
- int bank;
+ unsigned int bank;
msr_t sts;
};
@@ -148,7 +148,7 @@ static const char *const mca_bank_name[] = {
/* Check the Machine Check Architecture Extension registers */
void check_mca(void)
{
- int i;
+ unsigned int i;
struct mca_bank_status mci;
msr_t msr;
const unsigned int num_banks = mca_get_bank_count();
@@ -156,23 +156,23 @@ void check_mca(void)
for (i = 0 ; i < num_banks ; i++) {
mci.sts = rdmsr(MCAX_STATUS_MSR(i));
if (mci.sts.hi || mci.sts.lo) {
- printk(BIOS_WARNING, "#MC Error: core %u, bank %d %s\n",
+ printk(BIOS_WARNING, "#MC Error: core %u, bank %u %s\n",
initial_lapicid(), i,
i < ARRAY_SIZE(mca_bank_name) ? mca_bank_name[i] : "");
- printk(BIOS_WARNING, " MC%d_STATUS = %08x_%08x\n",
+ printk(BIOS_WARNING, " MC%u_STATUS = %08x_%08x\n",
i, mci.sts.hi, mci.sts.lo);
msr = rdmsr(MCAX_ADDR_MSR(i));
- printk(BIOS_WARNING, " MC%d_ADDR = %08x_%08x\n",
+ printk(BIOS_WARNING, " MC%u_ADDR = %08x_%08x\n",
i, msr.hi, msr.lo);
msr = rdmsr(MCAX_MISC0_MSR(i));
- printk(BIOS_WARNING, " MC%d_MISC = %08x_%08x\n",
+ printk(BIOS_WARNING, " MC%u_MISC = %08x_%08x\n",
i, msr.hi, msr.lo);
msr = rdmsr(MCAX_CTL_MSR(i));
- printk(BIOS_WARNING, " MC%d_CTL = %08x_%08x\n",
+ printk(BIOS_WARNING, " MC%u_CTL = %08x_%08x\n",
i, msr.hi, msr.lo);
msr = rdmsr(MCA_CTL_MASK_MSR(i));
- printk(BIOS_WARNING, " MC%d_CTL_MASK = %08x_%08x\n",
+ printk(BIOS_WARNING, " MC%u_CTL_MASK = %08x_%08x\n",
i, msr.hi, msr.lo);
mci.bank = i;