diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-02-10 01:32:00 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2021-02-11 00:50:52 +0000 |
| commit | a6fc2125e78eb7db537733ee7d33f59e723a27c1 (patch) | |
| tree | 57369317929a71f6863572bfdd1a4d8094ede3fd /src/soc/amd/picasso/smihandler.c | |
| parent | 4f69ab729a9e0fe929728c5726e78f7769fe5a3a (diff) | |
| download | coreboot-a6fc2125e78eb7db537733ee7d33f59e723a27c1.tar.gz coreboot-a6fc2125e78eb7db537733ee7d33f59e723a27c1.tar.bz2 coreboot-a6fc2125e78eb7db537733ee7d33f59e723a27c1.zip | |
soc/amd*/smihandler: factor out and rename clear_smi_sci_status
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifd6c3bebee1ccf7e7e7987d8ae3d9fa654019791
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50460
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/picasso/smihandler.c')
| -rw-r--r-- | src/soc/amd/picasso/smihandler.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c index 5134358cb765..626daad00a40 100644 --- a/src/soc/amd/picasso/smihandler.c +++ b/src/soc/amd/picasso/smihandler.c @@ -222,14 +222,6 @@ static const struct smi_sources_t smi_sources[] = { { .type = SMITYPE_SLP_TYP, .handler = sb_slp_typ_handler}, }; -static void process_smi_sci(void) -{ - const uint32_t status = smi_read32(SMI_SCI_STATUS); - - /* Clear events to prevent re-entering SMI if event isn't handled */ - smi_write32(SMI_SCI_STATUS, status); -} - static void *get_source_handler(int source) { int i; @@ -270,7 +262,8 @@ void southbridge_smi_handler(void) const uint16_t smi_src = smi_read16(SMI_REG_POINTER); if (smi_src & SMI_STATUS_SRC_SCI) - process_smi_sci(); + /* Clear events to prevent re-entering SMI if event isn't handled */ + clear_smi_sci_status(); if (smi_src & SMI_STATUS_SRC_0) process_smi_sources(SMI_REG_SMISTS0); if (smi_src & SMI_STATUS_SRC_1) |