summaryrefslogtreecommitdiffstats
path: root/src/soc/amd/picasso
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2024-01-25 18:53:54 +0100
committerFelix Held <felix-coreboot@felixheld.de>2024-01-26 18:12:11 +0000
commita4a2a4f033dc48a0a24d54f34364dd2ded627699 (patch)
tree267bf0d3f47cbd01cb884718a18e9532e0328c0d /src/soc/amd/picasso
parent3ac92e972d9c9c2ee113ea60eb1c3c5b0a61175a (diff)
downloadcoreboot-a4a2a4f033dc48a0a24d54f34364dd2ded627699.tar.gz
coreboot-a4a2a4f033dc48a0a24d54f34364dd2ded627699.tar.bz2
coreboot-a4a2a4f033dc48a0a24d54f34364dd2ded627699.zip
soc/amd: factor out common acpi_add_ivrs_table implementation
Instead of open-coding this functionality in all AMD SoCs, factor it out into a common implementation. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Idb65c398b747e70ec67107e0a1d4bd6551501347 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80208 Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/soc/amd/picasso')
-rw-r--r--src/soc/amd/picasso/agesa_acpi.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/soc/amd/picasso/agesa_acpi.c b/src/soc/amd/picasso/agesa_acpi.c
index 9ee977f2aca5..7a32779f60b0 100644
--- a/src/soc/amd/picasso/agesa_acpi.c
+++ b/src/soc/amd/picasso/agesa_acpi.c
@@ -542,7 +542,6 @@ static unsigned long acpi_fill_crat(struct acpi_crat_header *crat, unsigned long
uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current,
acpi_rsdp_t *rsdp)
{
- acpi_ivrs_t *ivrs;
struct acpi_crat_header *crat;
/* CRAT */
@@ -557,11 +556,7 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current
current = add_agesa_fsp_acpi_table(AMD_FSP_ACPI_ALIB_HOB_GUID, "ALIB", rsdp, current);
/* IVRS */
- current = acpi_align_current(current);
- ivrs = (acpi_ivrs_t *)current;
- acpi_create_ivrs(ivrs, acpi_fill_ivrs);
- current += ivrs->header.length;
- acpi_add_table(rsdp, ivrs);
+ current = acpi_add_ivrs_table(current, rsdp);
/* Add SRAT, MSCT, SLIT if needed in the future */