diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-12-05 00:41:05 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-12-06 16:01:18 +0000 |
| commit | f5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9 (patch) | |
| tree | 3f3224e9ceb971d762207c1c733e37b4d930e10c /src/soc/amd/stoneyridge | |
| parent | 3e306d48cd9f862e55e4458da0eb2c6a606cb796 (diff) | |
| download | coreboot-f5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9.tar.gz coreboot-f5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9.tar.bz2 coreboot-f5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9.zip | |
soc/amd/*/chipset.cb: don't call dummy device functions host bridges
Function 0 of the devices that have the bridges to other buses are dummy
functions that can be left enabled to not have to shuffle around the
device function numbers when the first PCI bridge on those devices isn't
enabled. Those dummy device functions are however not PCI host bridges,
so change the comments from 'Dummy Host Bridge' to 'Dummy device
function'.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Nico Huber <nico.h@gmx.de>
Change-Id: Ibddfdf558d84bc44434d718b86f41bd06044b22a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79396
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/amd/stoneyridge')
| -rw-r--r-- | src/soc/amd/stoneyridge/chipset_cz.cb | 4 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/chipset_st.cb | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/amd/stoneyridge/chipset_cz.cb b/src/soc/amd/stoneyridge/chipset_cz.cb index 1122ae833079..d45c6d7d5628 100644 --- a/src/soc/amd/stoneyridge/chipset_cz.cb +++ b/src/soc/amd/stoneyridge/chipset_cz.cb @@ -10,13 +10,13 @@ chip soc/amd/stoneyridge device pci 00.2 alias iommu off ops amd_iommu_ops end device pci 01.0 alias gfx off ops amd_graphics_ops end # internal GPU device pci 01.1 alias gfx_hda off end # display HD Audio controller - device pci 02.0 on end # Dummy Host Bridge, do not disable + device pci 02.0 on end # Dummy device function, do not disable device pci 02.1 alias gpp_bridge_0 off end device pci 02.2 alias gpp_bridge_1 off end device pci 02.3 alias gpp_bridge_2 off end device pci 02.4 alias gpp_bridge_3 off end device pci 02.5 alias gpp_bridge_4 off end - device pci 03.0 on end # Dummy Host Bridge, do not disable + device pci 03.0 on end # Dummy device function, do not disable device pci 03.1 alias gfx_bridge_0 off end device pci 03.2 alias gfx_bridge_1 off end device pci 03.3 alias gfx_bridge_2 off end diff --git a/src/soc/amd/stoneyridge/chipset_st.cb b/src/soc/amd/stoneyridge/chipset_st.cb index fd148a88d68f..0039ed97a7e5 100644 --- a/src/soc/amd/stoneyridge/chipset_st.cb +++ b/src/soc/amd/stoneyridge/chipset_st.cb @@ -10,7 +10,7 @@ chip soc/amd/stoneyridge device pci 00.2 alias iommu off ops amd_iommu_ops end device pci 01.0 alias gfx off ops amd_graphics_ops end # internal GPU device pci 01.1 alias gfx_hda off end # display HD Audio controller - device pci 02.0 on end # Dummy Host Bridge, do not disable + device pci 02.0 on end # Dummy device function, do not disable device pci 02.1 alias gpp_bridge_0 off end device pci 02.2 alias gpp_bridge_1 off end device pci 02.3 alias gpp_bridge_2 off end |