summaryrefslogtreecommitdiffstats
path: root/src/soc/intel/apollolake/bootblock/bootblock.c
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2022-02-01 19:01:36 +0530
committerMartin Roth <martinroth@google.com>2022-02-03 17:12:04 +0000
commit480e7e5ac88e35ce3ac8a1d30bac72b062d68878 (patch)
treeb3f059e1fc61524f3074e09002a712bbdc88b694 /src/soc/intel/apollolake/bootblock/bootblock.c
parent1d886639ce680010a21e64d7122dfcfa92a9f505 (diff)
downloadcoreboot-480e7e5ac88e35ce3ac8a1d30bac72b062d68878.tar.gz
coreboot-480e7e5ac88e35ce3ac8a1d30bac72b062d68878.tar.bz2
coreboot-480e7e5ac88e35ce3ac8a1d30bac72b062d68878.zip
soc/intel/apollolake: Rename PWRMBASE macro and function
This patch ensures PWRMBASE macro name and function to get PWRMBASE address on APL SoC is aligned with other IA SoC. PMC_BAR0 -> PCH_PWRM_BASE_ADDRESS read_pmc_mmio_bar() -> pmc_mmio_regs() Additionally, make `pmc_mmio_regs` a public function for other IA common code may need to get access to this function. BUG=None TEST=None Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: I3a61117f34b60ed6eeb9bda3ad853f0ffe6390f7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61532 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/soc/intel/apollolake/bootblock/bootblock.c')
-rw-r--r--src/soc/intel/apollolake/bootblock/bootblock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c
index 14e9b11ad240..fe0cb9377a84 100644
--- a/src/soc/intel/apollolake/bootblock/bootblock.c
+++ b/src/soc/intel/apollolake/bootblock/bootblock.c
@@ -62,7 +62,7 @@ static void enable_pmcbar(void)
pci_devfn_t pmc = PCH_DEV_PMC;
/* Set PMC base addresses and enable decoding. */
- pci_write_config32(pmc, PCI_BASE_ADDRESS_0, PMC_BAR0);
+ pci_write_config32(pmc, PCI_BASE_ADDRESS_0, PCH_PWRM_BASE_ADDRESS);
pci_write_config32(pmc, PCI_BASE_ADDRESS_1, 0); /* 64-bit BAR */
pci_write_config32(pmc, PCI_BASE_ADDRESS_2, PMC_BAR1);
pci_write_config32(pmc, PCI_BASE_ADDRESS_3, 0); /* 64-bit BAR */