diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-01-15 05:06:35 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-01-29 19:35:25 +0000 |
| commit | ca71e135bc68f9817c48da6393625c2cf93a2637 (patch) | |
| tree | b49f2029fbda580375ae1c4ed5116333946a6f11 /src/soc/intel/braswell | |
| parent | 816a41c904d1ba60ead3227bac83d5470f01c1ec (diff) | |
| download | coreboot-ca71e135bc68f9817c48da6393625c2cf93a2637.tar.gz coreboot-ca71e135bc68f9817c48da6393625c2cf93a2637.tar.bz2 coreboot-ca71e135bc68f9817c48da6393625c2cf93a2637.zip | |
soc/intel: Remove duplicate call to acpi_wake_source()
With SOC_INTEL_COMMON_BLOCK_ACPI=y the call was made twice,
possibly in the order:
common/block/acpi.c: acpi_wake_source()
common/acpi_wake_source.c: acpi_wake_source()
In this order later call would reset pm1i and gpei in GNVS.
Remove the implementation in block/acpi.c and rename existing
acpi_wake_source.c to block/acpi_wake_source.c.
Change-Id: I74fdae63111e3ea09000d888a918ebe70d711801
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49880
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/soc/intel/braswell')
| -rw-r--r-- | src/soc/intel/braswell/ramstage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/braswell/ramstage.c b/src/soc/intel/braswell/ramstage.c index 1a77b80f1ed9..e59f3eb8867f 100644 --- a/src/soc/intel/braswell/ramstage.c +++ b/src/soc/intel/braswell/ramstage.c @@ -10,6 +10,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> +#include <intelblocks/acpi_wake_source.h> #include <fsp/util.h> #include <soc/gpio.h> #include <soc/lpc.h> @@ -18,7 +19,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/ramstage.h> -#include <soc/intel/common/acpi.h> #include <string.h> #define SHOW_PATTRS 1 |