summaryrefslogtreecommitdiffstats
path: root/src/soc/intel/broadwell
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-02-19 16:08:36 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-03 09:07:59 +0000
commitd3a65deb255be26bdfbdae3b4b3625e4e3183a13 (patch)
tree1ed21c0c462fdd733ab6ffdcc52fedb086581dcb /src/soc/intel/broadwell
parentb0f52fb5bfa71d2ddf5741408cc14fcfdf8f5ffc (diff)
downloadcoreboot-d3a65deb255be26bdfbdae3b4b3625e4e3183a13.tar.gz
coreboot-d3a65deb255be26bdfbdae3b4b3625e4e3183a13.tar.bz2
coreboot-d3a65deb255be26bdfbdae3b4b3625e4e3183a13.zip
soc/intel: Guard macro parameters in pm.h
Guard against unintended operator precedence and associativity issues. Change-Id: I342682a57fde9942cdf7be10756ee21c10af802a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50917 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/broadwell')
-rw-r--r--src/soc/intel/broadwell/include/soc/pm.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/broadwell/include/soc/pm.h b/src/soc/intel/broadwell/include/soc/pm.h
index 40467ed1dd31..52fd36443020 100644
--- a/src/soc/intel/broadwell/include/soc/pm.h
+++ b/src/soc/intel/broadwell/include/soc/pm.h
@@ -62,7 +62,7 @@
#define GPE0_REG_MAX 4
#define GPE0_REG_SIZE 32
-#define GPE0_STS(x) (0x80 + (x * 4))
+#define GPE0_STS(x) (0x80 + ((x) * 4))
#define GPE_31_0 0 /* 0x80/0x90 = GPE[31:0] */
#define GPE_63_32 1 /* 0x84/0x94 = GPE[63:32] */
#define GPE_94_64 2 /* 0x88/0x98 = GPE[94:64] */
@@ -78,7 +78,7 @@
#define TCOSCI_STS (1 << 6)
#define SWGPE_STS (1 << 2)
#define HOT_PLUG_STS (1 << 1)
-#define GPE0_EN(x) (0x90 + (x * 4))
+#define GPE0_EN(x) (0x90 + ((x) * 4))
#define WADT_en (1 << 18)
#define GP27_EN (1 << 16)
#define PME_B0_EN (1 << 13)