summaryrefslogtreecommitdiffstats
path: root/src/soc/intel/cannonlake
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2021-12-12 13:08:26 +0100
committerFelix Singer <felixsinger@posteo.net>2021-12-13 12:56:04 +0000
commitb32599ea89f1fa43412348a9b968e1871dee6659 (patch)
tree199bc597b2e24fb6367d60c6658e9168c49f0122 /src/soc/intel/cannonlake
parentae0ea32c52905d6bcb527b04727463bc2d1b9e09 (diff)
downloadcoreboot-b32599ea89f1fa43412348a9b968e1871dee6659.tar.gz
coreboot-b32599ea89f1fa43412348a9b968e1871dee6659.tar.bz2
coreboot-b32599ea89f1fa43412348a9b968e1871dee6659.zip
soc/intel/cannonlake: Configure common FSP memory settings only once
`meminit_memcfg()` does common memory configuration, which is not specific to each DIMM. Thus, move it out of the for-loop and call it once. Change-Id: If74875b45cd0d7a759883eaf564505ebf281bed5 Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60058 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/intel/cannonlake')
-rw-r--r--src/soc/intel/cannonlake/cnl_memcfg_init.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c
index a9f9e95b7239..448e56cc7ae3 100644
--- a/src/soc/intel/cannonlake/cnl_memcfg_init.c
+++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c
@@ -136,7 +136,7 @@ void cannonlake_memcfg_init(FSP_M_CONFIG *mem_cfg,
default:
die("no valid way to read mem info");
}
-
- meminit_memcfg(mem_cfg, cnl_cfg);
}
+
+ meminit_memcfg(mem_cfg, cnl_cfg);
}