diff options
author | Arthur Heymans <arthur@aheymans.xyz> | 2022-12-02 12:42:27 +0100 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2022-12-06 17:06:35 +0000 |
commit | 8a3e2b836435f34a1031de190f48f02a8daf26db (patch) | |
tree | 7735f6d4ec3578b6a19a10d9c17ddaa3ebbb2114 /src/soc/intel/common/block/acpi | |
parent | 8a979d92c98f4ec2374b6f04a795ae65b4c52c5a (diff) | |
download | coreboot-8a3e2b836435f34a1031de190f48f02a8daf26db.tar.gz coreboot-8a3e2b836435f34a1031de190f48f02a8daf26db.tar.bz2 coreboot-8a3e2b836435f34a1031de190f48f02a8daf26db.zip |
soc/intel/xeon_sp: Read ioapic configuration from hardware
This is more robust than hardcoding whathever FSP has set up and is a
lot less code.
Change-Id: I6423ddc139d742879d791b054ea082768749c0a7
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70265
Reviewed-by: Jonathan Zhang <jonzhang@fb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/common/block/acpi')
-rw-r--r-- | src/soc/intel/common/block/acpi/acpi.c | 26 |
1 files changed, 9 insertions, 17 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 860c868cbe6f..010f23d287fe 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -73,34 +73,26 @@ static unsigned long acpi_madt_irq_overrides(unsigned long current) return current; } -__weak const struct madt_ioapic_info *soc_get_ioapic_info(size_t *entries) +static const uintptr_t default_ioapic_bases[] = { IO_APIC_ADDR }; + +__weak size_t soc_get_ioapic_info(const uintptr_t *ioapic_bases[]) { - *entries = 0; - return NULL; + *ioapic_bases = default_ioapic_bases; + return ARRAY_SIZE(default_ioapic_bases); } unsigned long acpi_fill_madt(unsigned long current) { - const struct madt_ioapic_info *ioapic_table; + const uintptr_t *ioapic_table; size_t ioapic_entries; /* Local APICs */ current = acpi_create_madt_lapics_with_nmis(current); /* IOAPIC */ - ioapic_table = soc_get_ioapic_info(&ioapic_entries); - if (ioapic_entries) { - for (int i = 0; i < ioapic_entries; i++) { - current += acpi_create_madt_ioapic( - (void *)current, - ioapic_table[i].id, - ioapic_table[i].addr, - ioapic_table[i].gsi_base); - } - } else { - /* Default SOC IOAPIC entry */ - current += acpi_create_madt_ioapic_from_hw((void *)current, IO_APIC_ADDR); - } + ioapic_entries = soc_get_ioapic_info(&ioapic_table); + for (int i = 0; i < ioapic_entries; i++) + current += acpi_create_madt_ioapic_from_hw((void *)current, ioapic_table[i]); return acpi_madt_irq_overrides(current); } |