diff options
author | Krishna Prasad Bhat <krishna.p.bhat.d@intel.com> | 2023-08-03 12:15:32 +0530 |
---|---|---|
committer | Sridhar Siricilla <sridhar.siricilla@intel.com> | 2023-08-04 04:50:25 +0000 |
commit | 6ba83484e6d54ddce7c3caccb79d4e7015cfeb37 (patch) | |
tree | 36be10463da1de45395ac6a755791121f52a067e /src/soc/intel/common/block/cse | |
parent | 5013c60a871af8fbce8c38a1c342c454e5b8452f (diff) | |
download | coreboot-6ba83484e6d54ddce7c3caccb79d4e7015cfeb37.tar.gz coreboot-6ba83484e6d54ddce7c3caccb79d4e7015cfeb37.tar.bz2 coreboot-6ba83484e6d54ddce7c3caccb79d4e7015cfeb37.zip |
soc/intel/common: Return CB_ERR when cse_data_clear_request() fails
cse_prep_for_rw_update() should return CB_ERR when
cse_data_clear_request fails. It was modified to CB_SUCCESS in this
commit ad6d3128f87c ("soc/intel/common: Use enum cb_err values")
BRANCH=None
BUG=None
TEST=Verify the system goes to recovery during downgrade when
cse_data_clear_request() fails.
Change-Id: Ibbccb827765afa54e5ab1b386fa46093b803977a
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76918
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/soc/intel/common/block/cse')
-rw-r--r-- | src/soc/intel/common/block/cse/cse_lite.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index d3fcec7ba42f..6203baaa4595 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -751,7 +751,7 @@ static enum cb_err cse_prep_for_rw_update(const struct cse_bp_info *cse_bp_info, if ((status == CSE_UPDATE_DOWNGRADE) || (status == CSE_UPDATE_CORRUPTED)) { if (cse_data_clear_request(cse_bp_info) != CB_SUCCESS) { printk(BIOS_ERR, "cse_lite: CSE data clear failed!\n"); - return CB_SUCCESS; + return CB_ERR; } } |