diff options
| author | Nico Huber <nico.h@gmx.de> | 2022-08-06 19:11:55 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-15 13:07:11 +0000 |
| commit | 576861994ea5011c3a836a826b8189ef79c366cb (patch) | |
| tree | 1d5dc30e477587ce2188d1472804322929659dcf /src/soc/intel/common/block/p2sb/p2sb.c | |
| parent | c0fc38eed8f407d71f714f4d6fe2af0c3501ece4 (diff) | |
| download | coreboot-576861994ea5011c3a836a826b8189ef79c366cb.tar.gz coreboot-576861994ea5011c3a836a826b8189ef79c366cb.tar.bz2 coreboot-576861994ea5011c3a836a826b8189ef79c366cb.zip | |
soc/intel/skylake: Assign device ops in chipset devicetree
Some PCI IDs were missing, and at least one (SPT's fast SPI
device in a generic SPI driver) was wrong. Hence, this patch
actually changes behavior depending on the devices actually
present in a machine.
In this patch the Skylake devicetree is written in a single-line
style. Alternative, the device operations could be put on a separate
line, e.g.
device pci 00.0 alias system_agent on
ops systemagent_ops
end
Tested on Kontron/bSL6. Notable in the log diff is that the
CSE and SATA drivers are hooked up now.
Change-Id: I8635fc53ca617b029d6fe1845eaef6c5c749db82
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66485
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc/intel/common/block/p2sb/p2sb.c')
| -rw-r--r-- | src/soc/intel/common/block/p2sb/p2sb.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/soc/intel/common/block/p2sb/p2sb.c b/src/soc/intel/common/block/p2sb/p2sb.c index 910f01d01cfe..d95e54121651 100644 --- a/src/soc/intel/common/block/p2sb/p2sb.c +++ b/src/soc/intel/common/block/p2sb/p2sb.c @@ -131,7 +131,7 @@ static void read_resources(struct device *dev) mmio_resource_kb(dev, PCI_BASE_ADDRESS_0, P2SB_BAR / KiB, P2SB_SIZE / KiB); } -static const struct device_operations device_ops = { +const struct device_operations p2sb_ops = { .read_resources = read_resources, .set_resources = noop_set_resources, .ops_pci = &pci_dev_ops_pci, @@ -144,9 +144,6 @@ static const unsigned short pci_device_ids[] = { PCI_DID_INTEL_GLK_P2SB, PCI_DID_INTEL_LWB_P2SB, PCI_DID_INTEL_LWB_P2SB_SUPER, - PCI_DID_INTEL_SKL_LP_P2SB, - PCI_DID_INTEL_SKL_P2SB, - PCI_DID_INTEL_KBL_P2SB, PCI_DID_INTEL_CNL_P2SB, PCI_DID_INTEL_CNP_H_P2SB, PCI_DID_INTEL_ICL_P2SB, @@ -163,7 +160,7 @@ static const unsigned short pci_device_ids[] = { }; static const struct pci_driver pmc __pci_driver = { - .ops = &device_ops, + .ops = &p2sb_ops, .vendor = PCI_VID_INTEL, .devices = pci_device_ids, }; |