diff options
| author | Nico Huber <nico.h@gmx.de> | 2022-08-06 19:11:55 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-15 13:07:11 +0000 |
| commit | 576861994ea5011c3a836a826b8189ef79c366cb (patch) | |
| tree | 1d5dc30e477587ce2188d1472804322929659dcf /src/soc/intel/common/block/spi | |
| parent | c0fc38eed8f407d71f714f4d6fe2af0c3501ece4 (diff) | |
| download | coreboot-576861994ea5011c3a836a826b8189ef79c366cb.tar.gz coreboot-576861994ea5011c3a836a826b8189ef79c366cb.tar.bz2 coreboot-576861994ea5011c3a836a826b8189ef79c366cb.zip | |
soc/intel/skylake: Assign device ops in chipset devicetree
Some PCI IDs were missing, and at least one (SPT's fast SPI
device in a generic SPI driver) was wrong. Hence, this patch
actually changes behavior depending on the devices actually
present in a machine.
In this patch the Skylake devicetree is written in a single-line
style. Alternative, the device operations could be put on a separate
line, e.g.
device pci 00.0 alias system_agent on
ops systemagent_ops
end
Tested on Kontron/bSL6. Notable in the log diff is that the
CSE and SATA drivers are hooked up now.
Change-Id: I8635fc53ca617b029d6fe1845eaef6c5c749db82
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66485
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc/intel/common/block/spi')
| -rw-r--r-- | src/soc/intel/common/block/spi/spi.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/soc/intel/common/block/spi/spi.c b/src/soc/intel/common/block/spi/spi.c index 34607184d8a6..dbafcf1c8e43 100644 --- a/src/soc/intel/common/block/spi/spi.c +++ b/src/soc/intel/common/block/spi/spi.c @@ -110,7 +110,7 @@ static struct spi_bus_operations spi_bus_ops = { .dev_to_bus = &spi_dev_to_bus, }; -static struct device_operations spi_dev_ops = { +struct device_operations spi_dev_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, @@ -124,9 +124,6 @@ static const unsigned short pci_device_ids[] = { PCI_DID_INTEL_MTL_GSPI0, PCI_DID_INTEL_MTL_GSPI1, PCI_DID_INTEL_MTL_GSPI2, - PCI_DID_INTEL_SPT_SPI1, - PCI_DID_INTEL_SPT_SPI2, - PCI_DID_INTEL_SPT_SPI3, PCI_DID_INTEL_APL_SPI0, PCI_DID_INTEL_APL_SPI1, PCI_DID_INTEL_APL_SPI2, |