diff options
| author | Michael Niewöhner <foss@mniewoehner.de> | 2020-10-12 20:03:59 +0200 |
|---|---|---|
| committer | Michael Niewöhner <foss@mniewoehner.de> | 2020-10-13 22:21:36 +0000 |
| commit | b73d2476dc2c52ec3310ee50b86b25186f98d25c (patch) | |
| tree | d51a5deebcc3fc87c9712074f1bfffe6775fcf84 /src/soc/intel/common/block/timer | |
| parent | 63975f0e68d90722b4aa312bbd4b4baca7418f13 (diff) | |
| download | coreboot-b73d2476dc2c52ec3310ee50b86b25186f98d25c.tar.gz coreboot-b73d2476dc2c52ec3310ee50b86b25186f98d25c.tar.bz2 coreboot-b73d2476dc2c52ec3310ee50b86b25186f98d25c.zip | |
soc/intel/common: rewrite and clarify the Legacy 8254 Timer Kconfig
The current Kconfig help text is confusing because it talks about
enabling the Kconfig for disabling a UPD for disabling power gating.
Rewrite and clarify the help text.
Change-Id: I9637c549db1ce29f259708f316852fc2ae9e7c38
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46302
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc/intel/common/block/timer')
| -rw-r--r-- | src/soc/intel/common/block/timer/Kconfig | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/soc/intel/common/block/timer/Kconfig b/src/soc/intel/common/block/timer/Kconfig index a214ef016b69..42613a8f84f4 100644 --- a/src/soc/intel/common/block/timer/Kconfig +++ b/src/soc/intel/common/block/timer/Kconfig @@ -8,7 +8,11 @@ config USE_LEGACY_8254_TIMER default y if PAYLOAD_SEABIOS || VGA_ROM_RUN default n help - This sets the FSP UPD to enable Legacy 8254 clock gating. As per - the FSP Integration guide Legacy 8254 timer clock gating UPD needs - to be disabled in order to boot SeaBIOS or run OpRom, - but should otherwise be enabled. + Setting this makes the Legacy 8254 Timer available by disabling + clock gating. This needs to be enabled in order to boot a legacy + BIOS or OS not supporting other timers like PM timer or TSC. + + While SeaBIOS does not require this timer anymore, it is needed + when OpRoms are being used. + + Disable this setting to save power, when the timer is not needed. |