diff options
| author | Uwe Poeche <uwe.poeche@siemens.com> | 2022-05-23 12:06:28 +0200 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2022-06-03 15:22:17 +0000 |
| commit | d2d90215435f05329bfc03d9351ee6f8f5351014 (patch) | |
| tree | 7522c210c6219c6aa81ca3a941be05443d3c0c59 /src/soc/intel/elkhartlake | |
| parent | 8da4bfe5b573f395057fbfb5a9d99b376e25c2a4 (diff) | |
| download | coreboot-d2d90215435f05329bfc03d9351ee6f8f5351014.tar.gz coreboot-d2d90215435f05329bfc03d9351ee6f8f5351014.tar.bz2 coreboot-d2d90215435f05329bfc03d9351ee6f8f5351014.zip | |
intel/common/block: move RAPL disabling to common code
This patch brings the feature of disabling RAPL to common code. It
replaces the current solution for APL and EHL.
For special case if RAPL disabling is only working via changes in MCHBAR
a new config switch was introduced.
Test: Boot mc_apl4/5 with this patch and ensure that the
relevant bits in MSR 0x610 are the same as before the
patch.
Change-Id: I2098ddcd2f19e3ebd87ef00c544e1427674f5e84
Signed-off-by: Uwe Poeche <uwe.poeche@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64596
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Diffstat (limited to 'src/soc/intel/elkhartlake')
| -rw-r--r-- | src/soc/intel/elkhartlake/systemagent.c | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/src/soc/intel/elkhartlake/systemagent.c b/src/soc/intel/elkhartlake/systemagent.c index 85623e8b0f66..a9fd26c603b0 100644 --- a/src/soc/intel/elkhartlake/systemagent.c +++ b/src/soc/intel/elkhartlake/systemagent.c @@ -48,7 +48,6 @@ void soc_systemagent_init(struct device *dev) { struct soc_power_limits_config *soc_config; config_t *config; - uint32_t value; /* Enable Power Aware Interrupt Routing */ enable_power_aware_intr(); @@ -57,16 +56,9 @@ void soc_systemagent_init(struct device *dev) enable_bios_reset_cpl(); mdelay(1); - if (CONFIG(SOC_INTEL_DISABLE_POWER_LIMITS)) { - printk(BIOS_INFO, "Skip setting RAPL per configuration\n"); - /* clear bits 47, 15 in PACKAGE_RAPL_LIMIT_0_0_0_MCHBAR_PCU */ - value = MCHBAR32(MCH_PKG_POWER_LIMIT_LO); - MCHBAR32(MCH_PKG_POWER_LIMIT_LO) = value & ~(PKG_PWR_LIM_1_EN); - value = MCHBAR32(MCH_PKG_POWER_LIMIT_HI); - MCHBAR32(MCH_PKG_POWER_LIMIT_HI) = value & ~(PKG_PWR_LIM_2_EN); - } else { - config = config_of_soc(); - soc_config = &config->power_limits_config; - set_power_limits(MOBILE_SKU_PL1_TIME_SEC, soc_config); - } + + config = config_of_soc(); + soc_config = &config->power_limits_config; + set_power_limits(MOBILE_SKU_PL1_TIME_SEC, soc_config); + } |