summaryrefslogtreecommitdiffstats
path: root/src/soc/intel/icelake/bootblock
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-02-19 22:01:55 +0100
committerAngel Pons <th3fanbus@gmail.com>2021-03-01 19:43:04 +0000
commit5d98dabb4e10cb93cae9b43f47dc3c4fe1fefd5f (patch)
tree195662824e02eed68659fd6a6b54087ac8439cbb /src/soc/intel/icelake/bootblock
parent43026ba81966a9f065435a68a6ca8bd69005fe19 (diff)
downloadcoreboot-5d98dabb4e10cb93cae9b43f47dc3c4fe1fefd5f.tar.gz
coreboot-5d98dabb4e10cb93cae9b43f47dc3c4fe1fefd5f.tar.bz2
coreboot-5d98dabb4e10cb93cae9b43f47dc3c4fe1fefd5f.zip
soc/intel: Drop `bootblock_cpu_init()` function
Just call `fast_spi_cache_bios_region()` directly instead. Change-Id: I99f6ed4cf1a5c49b078cfd05e357c2d4c26ade45 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50952 Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/icelake/bootblock')
-rw-r--r--src/soc/intel/icelake/bootblock/bootblock.c3
-rw-r--r--src/soc/intel/icelake/bootblock/cpu.c18
2 files changed, 2 insertions, 19 deletions
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c
index df1fb56234cb..ef5ada6239a6 100644
--- a/src/soc/intel/icelake/bootblock/bootblock.c
+++ b/src/soc/intel/icelake/bootblock/bootblock.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h>
+#include <intelblocks/fast_spi.h>
#include <intelblocks/systemagent.h>
#include <intelblocks/tco.h>
#include <intelblocks/uart.h>
@@ -16,7 +17,7 @@ void bootblock_soc_early_init(void)
{
bootblock_systemagent_early_init();
bootblock_pch_early_init();
- bootblock_cpu_init();
+ fast_spi_cache_bios_region();
pch_early_iorange_init();
if (CONFIG(INTEL_LPSS_UART_FOR_CONSOLE))
uart_bootblock_init();
diff --git a/src/soc/intel/icelake/bootblock/cpu.c b/src/soc/intel/icelake/bootblock/cpu.c
deleted file mode 100644
index bf5fc1be6531..000000000000
--- a/src/soc/intel/icelake/bootblock/cpu.c
+++ /dev/null
@@ -1,18 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <intelblocks/fast_spi.h>
-#include <soc/bootblock.h>
-
-void bootblock_cpu_init(void)
-{
- /*
- * Icelake platform doesn't support booting from any other media
- * (like eMMC on APL/GLK platform) than only booting from SPI device
- * and on IA platform SPI is memory mapped hence enabling temporarily
- * cacheing on memory-mapped spi boot media.
- *
- * This assumption will not hold good for APL/GLK platform where boot
- * from eMMC is also possible options.
- */
- fast_spi_cache_bios_region();
-}