diff options
author | Nico Huber <nico.h@gmx.de> | 2024-01-12 16:22:19 +0100 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2024-02-19 13:18:17 +0000 |
commit | 3d80d14cd4ed82e74057cea884dcb9bb7588c076 (patch) | |
tree | 2b871fd211af0a239a0926f28c787e3cd406cc90 /src/soc/intel/jasperlake/romstage/fsp_params.c | |
parent | 9bf38c7d672dbfe0771a15574a7e0c59f38c139c (diff) | |
download | coreboot-3d80d14cd4ed82e74057cea884dcb9bb7588c076.tar.gz coreboot-3d80d14cd4ed82e74057cea884dcb9bb7588c076.tar.bz2 coreboot-3d80d14cd4ed82e74057cea884dcb9bb7588c076.zip |
soc/intel/jasperlake: Drop redundant PcieRpEnable
The PcieRpEnable option is redundant to our on/off setting in the
devicetrees. Let's use the common coreboot infrastructure instead.
Thanks to Nicholas for doing all the mainboard legwork!
Change-Id: Iea7f616f6db579c06722369c08de7cf7261dece8
Signed-off-by: Nico Huber <nico.h@gmx.de>
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79919
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Jonathon Hall <jonathon.hall@puri.sm>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/jasperlake/romstage/fsp_params.c')
-rw-r--r-- | src/soc/intel/jasperlake/romstage/fsp_params.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/soc/intel/jasperlake/romstage/fsp_params.c b/src/soc/intel/jasperlake/romstage/fsp_params.c index 43a8c7003f8c..0132906534f4 100644 --- a/src/soc/intel/jasperlake/romstage/fsp_params.c +++ b/src/soc/intel/jasperlake/romstage/fsp_params.c @@ -5,8 +5,10 @@ #include <device/device.h> #include <fsp/util.h> #include <intelblocks/cpulib.h> +#include <intelblocks/pcie_rp.h> #include <soc/iomap.h> #include <soc/pci_devs.h> +#include <soc/pcie.h> #include <soc/romstage.h> #include <soc/soc_chip.h> @@ -14,7 +16,6 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_jasperlake_config *config) { unsigned int i; - uint32_t mask = 0; /* * If IGD is enabled, set IGD stolen size to 60MB. @@ -61,13 +62,7 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, } } - /* PCIe root port configuration */ - for (i = 0; i < ARRAY_SIZE(config->PcieRpEnable); i++) { - if (config->PcieRpEnable[i]) - mask |= (1 << i); - } - - m_cfg->PcieRpEnableMask = mask; + m_cfg->PcieRpEnableMask = pcie_rp_enable_mask(pch_rp_groups); FSP_ARRAY_LOAD(m_cfg->PcieClkSrcUsage, config->PcieClkSrcUsage); FSP_ARRAY_LOAD(m_cfg->PcieClkSrcClkReq, config->PcieClkSrcClkReq); |