summaryrefslogtreecommitdiffstats
path: root/src/soc/intel/jasperlake
diff options
context:
space:
mode:
authorJamie Chen <jamie.chen@intel.com>2022-03-15 16:16:30 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-04-22 21:36:34 +0000
commit5b58902749196787f881dd06bc109cca24dbe073 (patch)
tree4a9d9495c1a210bb2db7a0ed86a3655f0aa38dd1 /src/soc/intel/jasperlake
parentb30f8687b2a097c85b87b65b392833d43566c9d1 (diff)
downloadcoreboot-5b58902749196787f881dd06bc109cca24dbe073.tar.gz
coreboot-5b58902749196787f881dd06bc109cca24dbe073.tar.bz2
coreboot-5b58902749196787f881dd06bc109cca24dbe073.zip
soc/intel/jasperlake: CNVi: Enable fewer wakeups to reduce SoC power consumption
According to Intel TA#724456, work around the higher SoC power consumption in S0iX when CNVI has background activity. BUG=b:201263040 TEST=Turn on this setting and build and verify on Drawcia. The SLP_S0 toggling become slower or gone at the same CNVI background activity. Change-Id: I56439a406547e2ee1e47d34be14ecc9a8df04693 Signed-off-by: Jamie Chen <jamie.chen@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63675 Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Subrata Banik <subratabanik@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/jasperlake')
-rw-r--r--src/soc/intel/jasperlake/chip.h13
-rw-r--r--src/soc/intel/jasperlake/finalize.c5
-rw-r--r--src/soc/intel/jasperlake/include/soc/pmc.h5
3 files changed, 23 insertions, 0 deletions
diff --git a/src/soc/intel/jasperlake/chip.h b/src/soc/intel/jasperlake/chip.h
index f3e7240b57f4..398fe71699d2 100644
--- a/src/soc/intel/jasperlake/chip.h
+++ b/src/soc/intel/jasperlake/chip.h
@@ -421,6 +421,19 @@ struct soc_intel_jasperlake_config {
CD_CLOCK_652_8_MHZ = 9,
} cd_clock;
+ /*
+ * This is a workaround to mitigate higher SoC power consumption in S0ix
+ * when the CNVI has background activity.
+ *
+ * Setting this on a system that supports S0i3 (set xtalsdqdis [Bit 22] in
+ * cppmvric1 register to 0) will break CNVI timing.
+ * Affected Intel wireless chipsets: AC9560 (JfP2), AC9461/AC9462 (JfP1) and
+ * AX201 (HrP2)
+ *
+ * true: Enabled (fewer wakes, lower power)
+ * false: Disabled (more wakes, higher power)
+ */
+ bool cnvi_reduce_s0ix_pwr_usage;
};
typedef struct soc_intel_jasperlake_config config_t;
diff --git a/src/soc/intel/jasperlake/finalize.c b/src/soc/intel/jasperlake/finalize.c
index a3d4328e6b9d..3b0d49742ecd 100644
--- a/src/soc/intel/jasperlake/finalize.c
+++ b/src/soc/intel/jasperlake/finalize.c
@@ -59,6 +59,11 @@ static void pch_finalize(void)
reg32 = read32(pmcbase + CPPMVRIC3);
reg32 &= ~USBSUSPGQDIS;
write32(pmcbase + CPPMVRIC3, reg32);
+
+ if (config->cnvi_reduce_s0ix_pwr_usage) {
+ setbits32(pmcbase + CPPMVRIC2, CNVIVNNAONREQQDIS);
+ setbits32(pmcbase + CORE_SPARE_GCR_0, BIT(0));
+ }
}
pch_handle_sideband(config);
diff --git a/src/soc/intel/jasperlake/include/soc/pmc.h b/src/soc/intel/jasperlake/include/soc/pmc.h
index 1df2c63ab8ff..19226578106c 100644
--- a/src/soc/intel/jasperlake/include/soc/pmc.h
+++ b/src/soc/intel/jasperlake/include/soc/pmc.h
@@ -121,9 +121,14 @@
#define SLP_S0_RES 0x193c
+#define CORE_SPARE_GCR_0 0x195C
+
#define CPPMVRIC 0x1B1C
#define XTALSDQDIS (1 << 22)
+#define CPPMVRIC2 0x1B4C
+#define CNVIVNNAONREQQDIS (1 << 26)
+
#define CPPMVRIC3 0x1E4C
#define USBSUSPGQDIS (1 << 15)