diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2019-07-26 14:22:09 +0200 |
|---|---|---|
| committer | Patrick Rudolph <siro@das-labor.org> | 2019-08-06 12:03:18 +0000 |
| commit | be207b10988cd81b0f8da16cac958e8456987a69 (patch) | |
| tree | a7348d4f98d1455a01e61eb8f92eb04d7372b9d8 /src/soc/intel/skylake/cpu.c | |
| parent | 09370df845d12d18a178ac95d60bf5a742cfc84b (diff) | |
| download | coreboot-be207b10988cd81b0f8da16cac958e8456987a69.tar.gz coreboot-be207b10988cd81b0f8da16cac958e8456987a69.tar.bz2 coreboot-be207b10988cd81b0f8da16cac958e8456987a69.zip | |
soc/*: Report mp_init errors
* Increase log level from ERR to CRITICAL in run_ap_work().
* Print or return errors if mp_run_on_all_cpus() failed.
Tested on Supermicro X11SSH-TF.
Change-Id: I740505e3b6a46ebb3311d0e6b9669e7f929f9ab9
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34586
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc/intel/skylake/cpu.c')
| -rw-r--r-- | src/soc/intel/skylake/cpu.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c index cb0ceaa0bcfe..eecb0048b9f5 100644 --- a/src/soc/intel/skylake/cpu.c +++ b/src/soc/intel/skylake/cpu.c @@ -476,6 +476,8 @@ static void fc_lock_configure(void *unused) static void post_mp_init(void) { + int ret = 0; + /* Set Max Ratio */ cpu_set_max_ratio(); @@ -489,11 +491,14 @@ static void post_mp_init(void) if (CONFIG(HAVE_SMI_HANDLER)) smm_lock(); - mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC); + ret |= mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC); + + ret |= mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC); - mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC); + ret |= mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC); - mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC); + if (ret) + printk(BIOS_CRIT, "CRITICAL ERROR: MP post init failed\n"); } static const struct mp_ops mp_ops = { |