diff options
| author | Barnali Sarkar <barnali.sarkar@intel.com> | 2016-08-02 17:49:56 +0530 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-08-08 18:18:57 +0200 |
| commit | 0dddcd76d74274715b0472ca41ddac88a5203b84 (patch) | |
| tree | e4c6370329abc5f2d3a283bf0b88cfab06c85a82 /src/soc/intel/skylake/elog.c | |
| parent | 5d3d69ca950c728878d3fb0a26bc3be0b91bf406 (diff) | |
| download | coreboot-0dddcd76d74274715b0472ca41ddac88a5203b84.tar.gz coreboot-0dddcd76d74274715b0472ca41ddac88a5203b84.tar.bz2 coreboot-0dddcd76d74274715b0472ca41ddac88a5203b84.zip | |
soc/intel/skylake: Cleanup patch for Skylake SoC
Here is the list of items of code cleanup
1. Define TCO registers in smbus.h and not in pmc.h (as per EDS).
2. Include smbus.h wherever these TCO register defines were used.
3. Remove duplication of define in gpio_defs.h.
4. Remove unnecessary console.h include from memmap.h as no prints done.
5. Remove unnecessary comment from pch.c.
BUG=none
BRANCH=none
TEST=Built and boot kunimitsu.
Change-Id: Ibe6d2537ddde3c1c7f8ea5ada1bfaa9be79c0e3b
Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Reviewed-on: https://review.coreboot.org/16027
Tested-by: build bot (Jenkins)
Reviewed-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Diffstat (limited to 'src/soc/intel/skylake/elog.c')
| -rw-r--r-- | src/soc/intel/skylake/elog.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index ca6455e4964f..8d5d4fec6371 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -20,7 +20,7 @@ #include <stdint.h> #include <elog.h> #include <soc/pm.h> -#include <soc/pmc.h> +#include <soc/smbus.h> static void pch_log_gpio_gpe(u32 gpe0_sts, u32 gpe0_en, int start) { |