diff options
| author | Yu-Ping Wu <yupingso@chromium.org> | 2021-07-23 16:17:11 +0800 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2021-08-02 15:01:54 +0000 |
| commit | 941db0e55ce85501bdb557bd72d8980c01b5ccd3 (patch) | |
| tree | 22f917b4741576da9ed6553f6d19ebe4ec1ab09a /src/soc/mediatek/mt8195/include/soc | |
| parent | 5d71994c02b2808078e142fc112b0f6615fa9c62 (diff) | |
| download | coreboot-941db0e55ce85501bdb557bd72d8980c01b5ccd3.tar.gz coreboot-941db0e55ce85501bdb557bd72d8980c01b5ccd3.tar.bz2 coreboot-941db0e55ce85501bdb557bd72d8980c01b5ccd3.zip | |
helpers: Add GENMASK macro
The GENMASK is defined in multiple files (with various names such as
MASKBIT), which sets certain consecutive bits to 1 and leaves the others
to 0. To avoid duplicate macros, add GENMASK macro to helpers.h.
GENMASK(high, low) sets bits from `high` to `low` (inclusive) to 1. For
example, GENMASK(39, 21) gives us the 64-bit vector 0x000000ffffe00000.
Remove duplicate macro definitions. Also utilize GENMASK for _BF_MASK in
mmio.h.
BUG=none
TEST=make tests/commonlib/bsd/helpers-test
TEST=emerge-cherry coreboot
BRANCH=none
Change-Id: If2e7c4827d8a7d27688534593b556a72f16f0c2b
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56543
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/soc/mediatek/mt8195/include/soc')
| -rw-r--r-- | src/soc/mediatek/mt8195/include/soc/dptx_hal.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/soc/mediatek/mt8195/include/soc/dptx_hal.h b/src/soc/mediatek/mt8195/include/soc/dptx_hal.h index b943c27cfaff..dcb171705b4b 100644 --- a/src/soc/mediatek/mt8195/include/soc/dptx_hal.h +++ b/src/soc/mediatek/mt8195/include/soc/dptx_hal.h @@ -15,8 +15,6 @@ #define DP_AUX_NATIVE_WRITE 0x8 #define DP_AUX_NATIVE_READ 0x9 -#define MASKBIT(a, b) ((a > b) ? (BIT(a + 1) - BIT(b)) : (BIT(b + 1) - BIT(a))) - #define DP_WRITE1BYTE(mtk_dp, reg, u8_val) \ mtk_dp_write_byte(mtk_dp, reg, u8_val, 0xff) #define DP_WRITE2BYTE(mtk_dp, reg, u16_val) \ |