diff options
| author | Paul Menzel <pmenzel@molgen.mpg.de> | 2022-06-10 11:43:01 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-07-12 22:12:19 +0000 |
| commit | 42a7cd0d99cfe4016d234e71b25aada8b453ba2f (patch) | |
| tree | b0c2c88978c5be4a41cb60681861df1050ff47cd /src/soc | |
| parent | 5c2b5fcf2f9c9259938fd03cfa3ea06b36a007f0 (diff) | |
| download | coreboot-42a7cd0d99cfe4016d234e71b25aada8b453ba2f.tar.gz coreboot-42a7cd0d99cfe4016d234e71b25aada8b453ba2f.tar.bz2 coreboot-42a7cd0d99cfe4016d234e71b25aada8b453ba2f.zip | |
soc/samsung/exynos5420: Use int instead of char for count variable
This micro optimization of using unsigned char instead of unsigned
integer actually generates one more instruction.
.LVL296: .LVL296:
.L198: .L198:
.loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740 .loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740
uxtb r2, r3 | cmp r7, r3
cmp r7, r2 <
bhi .L199 bhi .L199
.loc 1 916 1 is_stmt 0 view .LVU1741 .loc 1 916 1 is_stmt 0 view .LVU1741
add sp, sp, #36 add sp, sp, #36
.cfi_remember_state .cfi_remember_state
.cfi_def_cfa_offset 20 .cfi_def_cfa_offset 20
@ sp needed @ sp needed
pop {r4, r5, r6, r7, pc} pop {r4, r5, r6, r7, pc}
Fix it, so nobody can copy that.
Change-Id: If5ffeacc7ac3c53a82b260cfb81ef7debc40034a
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65731
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/samsung/exynos5420/dp_lowlevel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/samsung/exynos5420/dp_lowlevel.c b/src/soc/samsung/exynos5420/dp_lowlevel.c index 61445442af15..0cd64833f477 100644 --- a/src/soc/samsung/exynos5420/dp_lowlevel.c +++ b/src/soc/samsung/exynos5420/dp_lowlevel.c @@ -894,7 +894,7 @@ void exynos_dp_set_lanex_pre_emphasis(unsigned char request_val, void exynos_dp_set_lane_pre_emphasis(unsigned int level, unsigned char lanecnt) { - unsigned char i; + unsigned int i; u32 reg; void *reg_list[DP_LANE_CNT_4] = { &dp_regs->ln0_link_training_ctl, |