diff options
| author | Rex-BC Chen <rex-bc.chen@mediatek.com> | 2022-07-20 11:35:57 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-07-21 10:33:22 +0000 |
| commit | c5d4d964f1728dad5a60d84b8ee0febe0426678b (patch) | |
| tree | e6418c4f4bcf1e36f4ca34d7828ab218c4666ee1 /src/soc | |
| parent | d5dafb2c0a6bac5c9d87f0e07e339570e0fd3267 (diff) | |
| download | coreboot-c5d4d964f1728dad5a60d84b8ee0febe0426678b.tar.gz coreboot-c5d4d964f1728dad5a60d84b8ee0febe0426678b.tar.bz2 coreboot-c5d4d964f1728dad5a60d84b8ee0febe0426678b.zip | |
mb/google: Use boolean type for "enable" argument for regulator
Because 0 and 1 are the only possible values,
1. Change input argument "enable" of mainboard_enable_regulator to bool.
2. Change return value of mainboard_regulator_is_enabled() to bool.
TEST=build pass
BUG=b:233720142
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Change-Id: Iae09c5fedf8f7394bfbb677e5aee37ed061304fd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65997
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/mediatek/common/include/soc/regulator.h | 4 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8192/msdc.c | 5 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8195/msdc.c | 4 |
3 files changed, 6 insertions, 7 deletions
diff --git a/src/soc/mediatek/common/include/soc/regulator.h b/src/soc/mediatek/common/include/soc/regulator.h index 0acf91059da5..2ff122637a4e 100644 --- a/src/soc/mediatek/common/include/soc/regulator.h +++ b/src/soc/mediatek/common/include/soc/regulator.h @@ -25,7 +25,7 @@ enum mtk_regulator { void mainboard_set_regulator_voltage(enum mtk_regulator regulator, uint32_t voltage_uv); uint32_t mainboard_get_regulator_voltage(enum mtk_regulator regulator); -int mainboard_enable_regulator(enum mtk_regulator regulator, uint8_t enable); -uint8_t mainboard_regulator_is_enabled(enum mtk_regulator regulator); +int mainboard_enable_regulator(enum mtk_regulator regulator, bool enable); +bool mainboard_regulator_is_enabled(enum mtk_regulator regulator); #endif /* SOC_MEDIATEK_COMMON_REGULATOR_H */ diff --git a/src/soc/mediatek/mt8192/msdc.c b/src/soc/mediatek/mt8192/msdc.c index 113069a27b6d..89f25a3adf8c 100644 --- a/src/soc/mediatek/mt8192/msdc.c +++ b/src/soc/mediatek/mt8192/msdc.c @@ -57,7 +57,6 @@ void mtk_msdc_configure_sdcard(void) void *gpio_base = (void *)IOCFG_RM_BASE; void *gpio_mode0_base = (void *)MSDC1_GPIO_MODE0_BASE; void *gpio_mode1_base = (void *)MSDC1_GPIO_MODE1_BASE; - uint8_t enable = 1; int i; const gpio_t sdcard_pu_pin[] = { @@ -85,6 +84,6 @@ void mtk_msdc_configure_sdcard(void) /* set sdcard dat1 pin to msdc1 mode */ clrsetbits32(gpio_mode1_base, MSDC1_GPIO_MODE1_MASK, MSDC1_GPIO_MODE1_VALUE); - mainboard_enable_regulator(MTK_REGULATOR_VCC, enable); - mainboard_enable_regulator(MTK_REGULATOR_VCCQ, enable); + mainboard_enable_regulator(MTK_REGULATOR_VCC, true); + mainboard_enable_regulator(MTK_REGULATOR_VCCQ, true); } diff --git a/src/soc/mediatek/mt8195/msdc.c b/src/soc/mediatek/mt8195/msdc.c index bbfeaa6c81e0..5f75c6444eed 100644 --- a/src/soc/mediatek/mt8195/msdc.c +++ b/src/soc/mediatek/mt8195/msdc.c @@ -103,6 +103,6 @@ void mtk_msdc_configure_sdcard(void) if (CONFIG(BOARD_GOOGLE_CHERRY)) mt6360_init(I2C7); - mainboard_enable_regulator(MTK_REGULATOR_VCCQ, 1); - mainboard_enable_regulator(MTK_REGULATOR_VCC, 1); + mainboard_enable_regulator(MTK_REGULATOR_VCCQ, true); + mainboard_enable_regulator(MTK_REGULATOR_VCC, true); } |