diff options
| author | Fabio Aiuto <fabioaiuto83@gmail.com> | 2022-09-30 11:25:28 +0200 |
|---|---|---|
| committer | Martin Roth <martin.roth@amd.corp-partner.google.com> | 2022-10-06 18:32:21 +0000 |
| commit | d835da91552bc74892dce7b9d2aafb74ce86b1f2 (patch) | |
| tree | 9930a94e31587b8f64dad63aab25971b15a3328f /src/southbridge | |
| parent | 4fce79f69c04094fcdd6f2ee89e06a1a776a7deb (diff) | |
| download | coreboot-d835da91552bc74892dce7b9d2aafb74ce86b1f2.tar.gz coreboot-d835da91552bc74892dce7b9d2aafb74ce86b1f2.tar.bz2 coreboot-d835da91552bc74892dce7b9d2aafb74ce86b1f2.zip | |
treewide: use predicates to check for enabled pci devices
use functions to check for pci devices instead of open-coded
solution.
TEST: compiled and qemu run successfully
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68102
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge')
| -rw-r--r-- | src/southbridge/intel/bd82x6x/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801gx/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801ix/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801jx/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/ibexpeak/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/lynxpoint/lpc.c | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index b2e6344143a1..46351890cddd 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -104,7 +104,7 @@ static void pch_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin=0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index a12e36bc589f..4d8270638c3a 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -86,7 +86,7 @@ static void i82801gx_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 9f70d1f8be9f..e39c95a50483 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -89,7 +89,7 @@ static void i82801ix_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index e3881ffa133e..41bcccd9e000 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -98,7 +98,7 @@ static void i82801jx_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 1735020b5448..d4e3098ad290 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -96,7 +96,7 @@ static void pch_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin=0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 7ae847b79b56..20e40cbacbc0 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -120,7 +120,7 @@ static void pch_pirq_init(struct device *dev) for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; - if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI) + if (!is_enabled_pci(irq_dev)) continue; int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN); |