summaryrefslogtreecommitdiffstats
path: root/src/superio/fintek
diff options
context:
space:
mode:
authorNicholas Sudsgaard <devel+coreboot@nsudsgaard.com>2024-01-30 09:53:46 +0900
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2024-01-31 09:51:58 +0000
commitbfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch)
tree0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/superio/fintek
parentf4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff)
downloadcoreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.gz
coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.bz2
coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.zip
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/superio/fintek')
-rw-r--r--src/superio/fintek/f71808a/superio.c2
-rw-r--r--src/superio/fintek/f71859/superio.c2
-rw-r--r--src/superio/fintek/f71863fg/superio.c2
-rw-r--r--src/superio/fintek/f71869ad/superio.c2
-rw-r--r--src/superio/fintek/f81803a/superio.c2
-rw-r--r--src/superio/fintek/f81865f/superio.c2
-rw-r--r--src/superio/fintek/f81866d/superio.c2
7 files changed, 7 insertions, 7 deletions
diff --git a/src/superio/fintek/f71808a/superio.c b/src/superio/fintek/f71808a/superio.c
index 17fa379df43b..885d3f7586a4 100644
--- a/src/superio/fintek/f71808a/superio.c
+++ b/src/superio/fintek/f71808a/superio.c
@@ -51,6 +51,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f71808a_ops = {
- CHIP_NAME("Fintek F71808A Super I/O")
+ .name = "Fintek F71808A Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f71859/superio.c b/src/superio/fintek/f71859/superio.c
index 1f4424954f71..628d4c952ba0 100644
--- a/src/superio/fintek/f71859/superio.c
+++ b/src/superio/fintek/f71859/superio.c
@@ -33,6 +33,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f71859_ops = {
- CHIP_NAME("Fintek F71859 Super I/O")
+ .name = "Fintek F71859 Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f71863fg/superio.c b/src/superio/fintek/f71863fg/superio.c
index c4e8dc98733b..6f1735d7a259 100644
--- a/src/superio/fintek/f71863fg/superio.c
+++ b/src/superio/fintek/f71863fg/superio.c
@@ -50,6 +50,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f71863fg_ops = {
- CHIP_NAME("Fintek F71863FG Super I/O")
+ .name = "Fintek F71863FG Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f71869ad/superio.c b/src/superio/fintek/f71869ad/superio.c
index 3cfd387df474..a4affee0d88c 100644
--- a/src/superio/fintek/f71869ad/superio.c
+++ b/src/superio/fintek/f71869ad/superio.c
@@ -107,6 +107,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f71869ad_ops = {
- CHIP_NAME("Fintek F71869AD Super I/O")
+ .name = "Fintek F71869AD Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f81803a/superio.c b/src/superio/fintek/f81803a/superio.c
index 5304f9edc6f4..4d4e8bc461c2 100644
--- a/src/superio/fintek/f81803a/superio.c
+++ b/src/superio/fintek/f81803a/superio.c
@@ -57,6 +57,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f81803a_ops = {
- CHIP_NAME("Fintek F81803A Super I/O")
+ .name = "Fintek F81803A Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f81865f/superio.c b/src/superio/fintek/f81865f/superio.c
index 9181bad98776..70fefe50cbfa 100644
--- a/src/superio/fintek/f81865f/superio.c
+++ b/src/superio/fintek/f81865f/superio.c
@@ -48,6 +48,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f81865f_ops = {
- CHIP_NAME("Fintek F81865F Super I/O")
+ .name = "Fintek F81865F Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/fintek/f81866d/superio.c b/src/superio/fintek/f81866d/superio.c
index 3803230d5576..6bcf311045f4 100644
--- a/src/superio/fintek/f81866d/superio.c
+++ b/src/superio/fintek/f81866d/superio.c
@@ -73,6 +73,6 @@ static void enable_dev(struct device *dev)
}
struct chip_operations superio_fintek_f81866d_ops = {
- CHIP_NAME("Fintek F81866AD-I Super I/O")
+ .name = "Fintek F81866AD-I Super I/O",
.enable_dev = enable_dev
};