diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
| commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
| tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/superio/nsc | |
| parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) | |
| download | coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.gz coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.bz2 coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.zip | |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/superio/nsc')
| -rw-r--r-- | src/superio/nsc/pc87382/superio.c | 2 | ||||
| -rw-r--r-- | src/superio/nsc/pc87384/superio.c | 2 | ||||
| -rw-r--r-- | src/superio/nsc/pc87392/superio.c | 2 | ||||
| -rw-r--r-- | src/superio/nsc/pc87417/superio.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/superio/nsc/pc87382/superio.c b/src/superio/nsc/pc87382/superio.c index 355aca49ab2b..c60e84547cfb 100644 --- a/src/superio/nsc/pc87382/superio.c +++ b/src/superio/nsc/pc87382/superio.c @@ -41,6 +41,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_nsc_pc87382_ops = { - CHIP_NAME("NSC PC87382 Docking LPC Switch") + .name = "NSC PC87382 Docking LPC Switch", .enable_dev = enable_dev, }; diff --git a/src/superio/nsc/pc87384/superio.c b/src/superio/nsc/pc87384/superio.c index 88d4d3699089..60e0994281f4 100644 --- a/src/superio/nsc/pc87384/superio.c +++ b/src/superio/nsc/pc87384/superio.c @@ -25,6 +25,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_nsc_pc87384_ops = { - CHIP_NAME("NSC PC87384 Super I/O") + .name = "NSC PC87384 Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/nsc/pc87392/superio.c b/src/superio/nsc/pc87392/superio.c index e65afeab6eed..551249d78fa5 100644 --- a/src/superio/nsc/pc87392/superio.c +++ b/src/superio/nsc/pc87392/superio.c @@ -35,6 +35,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_nsc_pc87392_ops = { - CHIP_NAME("NSC PC87392 Super I/O") + .name = "NSC PC87392 Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/nsc/pc87417/superio.c b/src/superio/nsc/pc87417/superio.c index be99f7f03165..ac01c4618f8d 100644 --- a/src/superio/nsc/pc87417/superio.c +++ b/src/superio/nsc/pc87417/superio.c @@ -46,6 +46,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_nsc_pc87417_ops = { - CHIP_NAME("NSC PC87417 Super I/O") + .name = "NSC PC87417 Super I/O", .enable_dev = enable_dev, }; |