diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-16 14:55:46 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-05-28 04:18:19 +0000 |
| commit | 704ccafb392212cffc3810197da5cb2b619f1ba6 (patch) | |
| tree | 7318075446c17ce7f64de57a7371135b8e542c72 /src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h | |
| parent | 8d3640d22610eeb9a21c803d75c698e681a1dc62 (diff) | |
| download | coreboot-704ccafb392212cffc3810197da5cb2b619f1ba6.tar.gz coreboot-704ccafb392212cffc3810197da5cb2b619f1ba6.tar.bz2 coreboot-704ccafb392212cffc3810197da5cb2b619f1ba6.zip | |
vendorcode/amd/agesa/f14: Fix improper use of .data
AGESA has a lot of code in the .data section which is for initialized
data, that in fact should be .rodata. This adds the 'CONST' keyword
everywhere it is needed.
TEST: See in the .elf file (e.g. using readelf) that there is nothing in
.data section.
Change-Id: I657d09f05070f5a88a4a162872c961db869a8df3
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64399
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h')
| -rw-r--r-- | src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h b/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h index a17906a448a9..eec43b050ab7 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h +++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h @@ -465,7 +465,7 @@ typedef struct _MEM_NB_BLOCK { CH_DEF_STRUCT *ChannelPtr; ///< point to current channel data SPD_DEF_STRUCT *SPDPtr; ///< Point to SPD data for current DCT. struct _MEM_TECH_BLOCK *TechPtr; ///< point to technology block. - struct _MEM_FEAT_BLOCK_NB *FeatPtr; ///< point to NB Specific feature block. + CONST struct _MEM_FEAT_BLOCK_NB *FeatPtr; ///< point to NB Specific feature block. struct _MEM_SHARED_DATA *SharedPtr; ///< Pointer to Memory scratchpad area SPD_DEF_STRUCT *AllNodeSPDPtr; ///< Point to SPD data for the system. DIE_STRUCT *AllNodeMCTPtr; ///< point to all Node's MCT structs @@ -1384,6 +1384,3 @@ MemNBfAfExcludeDimmClientNb ( ); #endif /* _MN_H_ */ - - - |