diff options
author | Kostr <aladyshev@nicevt.ru> | 2012-10-08 22:04:53 +0400 |
---|---|---|
committer | Marc Jones <marcj303@gmail.com> | 2012-10-30 05:49:13 +0100 |
commit | 335450d0a1f7befe4ca649d7e23dcf8ed15bf314 (patch) | |
tree | 02c4d49e1ff31c9f2e089ed96144bc224b14b25c /src/vendorcode/amd/agesa/f15/Makefile.inc | |
parent | 80adfdf8a9dde4b81fc0d0ffacf04835c4eaa883 (diff) | |
download | coreboot-335450d0a1f7befe4ca649d7e23dcf8ed15bf314.tar.gz coreboot-335450d0a1f7befe4ca649d7e23dcf8ed15bf314.tar.bz2 coreboot-335450d0a1f7befe4ca649d7e23dcf8ed15bf314.zip |
Fix ExecuteFinalHltInstruction function in f15h family code
Current ExecuteFinalHltInstruction function doesn't work well.
(at least in configuration
Supermicro board with Orochi AMD Opteron processors (model OS6234WKTCGGU))
System reboots when trying to halt core 2,4,6,8 or 10
(OS6234WKTCGGU is 12 core processor)
Based on this information, i think that code doesn't really work with
f15 compute unit (CU) system.
Replacing ExecuteFinalHltInstruction function with
analogous function from f15tn family code fix this problem.
Both functions written from the same cahalt.asm file, but f15tn version
seems more completed
Change-Id: I3942abcdf21f1b86a44c01cc477714e44a40b9cf
Signed-off-by: Kostr <aladyshev@nicevt.ru>
Reviewed-on: http://review.coreboot.org/1569
Tested-by: build bot (Jenkins)
Reviewed-by: Siyuan Wang <wangsiyuanbuaa@gmail.com>
Reviewed-by: Marc Jones <marcj303@gmail.com>
Diffstat (limited to 'src/vendorcode/amd/agesa/f15/Makefile.inc')
-rw-r--r-- | src/vendorcode/amd/agesa/f15/Makefile.inc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/vendorcode/amd/agesa/f15/Makefile.inc b/src/vendorcode/amd/agesa/f15/Makefile.inc index 1f3ba5179c82..0762b082313d 100644 --- a/src/vendorcode/amd/agesa/f15/Makefile.inc +++ b/src/vendorcode/amd/agesa/f15/Makefile.inc @@ -88,6 +88,7 @@ agesa_lib_src += ./Proc/Common/CommonReturns.c agesa_lib_src += ./Proc/Common/CreateStruct.c agesa_lib_src += ./Proc/Common/S3RestoreState.c agesa_lib_src += ./Proc/Common/S3SaveState.c +agesa_lib_src += ./Proc/CPU/cahaltasm.S agesa_lib_src += ./Proc/CPU/cahalt.c agesa_lib_src += ./Proc/CPU/cpuApicUtilities.c agesa_lib_src += ./Proc/CPU/cpuBist.c |