diff options
| author | Kane Chen <kane.chen@intel.corp-partner.google.com> | 2023-08-02 15:29:21 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-08-04 14:05:15 +0000 |
| commit | 2d8bc345cbc274aac402df7e5232885074591f38 (patch) | |
| tree | 43d1949539384ace74e12ee39b0ab238713ab154 /src | |
| parent | 4202a2cbf6263ae68e839f60f9bd243745f44521 (diff) | |
| download | coreboot-2d8bc345cbc274aac402df7e5232885074591f38.tar.gz coreboot-2d8bc345cbc274aac402df7e5232885074591f38.tar.bz2 coreboot-2d8bc345cbc274aac402df7e5232885074591f38.zip | |
soc/intel/mtl: Change default for debug consent from 3 to 6
USB DBC is very helpful for SoC debug. TraceHub needs to be enabled in
coreboot if debug consent == 2 or 4. Debug consent == 6 enables USB DBC without TraceHub enabled.
This patch updates the Kconfig help text to meet PlatformDebugOption in
MTL and changes debug consent to 6 in default to provide basic SoC
debug capability.
TEST=Boot to OS on screebo and DBC connection is OK.
Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2
Signed-off-by: Kane Chen <kane.chen@intel.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76880
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/intel/meteorlake/Kconfig | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 3fa1347e8293..8f4e3a240538 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -345,9 +345,9 @@ config FSP_FD_PATH config SOC_INTEL_METEORLAKE_DEBUG_CONSENT int "Debug Consent for MTL" - # USB DBC is more common for developers so make this default to 3 if + # USB DBC is more common for developers so make this default to 6 if # SOC_INTEL_DEBUG_CONSENT=y - default 3 if SOC_INTEL_DEBUG_CONSENT + default 6 if SOC_INTEL_DEBUG_CONSENT default 0 help This is to control debug interface on SOC. @@ -355,9 +355,8 @@ config SOC_INTEL_METEORLAKE_DEBUG_CONSENT PlatformDebugConsent in FspmUpd.h has the details. Desired platform debug type are - 0:Disabled, 1:Enabled (DCI OOB+[DbC]), 2:Enabled (DCI OOB), - 3:Enabled (USB3 DbC), 4:Enabled (XDP/MIPI60), 5:Enabled (USB2 DbC), - 6:Enable (2-wire DCI OOB), 7:Manual + 0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready, + 6:Enable Trace Power-Off, 7:Manual config DATA_BUS_WIDTH int |