summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorTim Wawrzynczak <twawrzynczak@chromium.org>2022-06-27 11:10:26 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-06-29 15:08:25 +0000
commit2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7 (patch)
tree52b7096dcecb09759d1ba150d76fa55f37a2cdcc /src
parentdc1c7807049ffccb0d13bbdf1f2630e28929d6fd (diff)
downloadcoreboot-2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7.tar.gz
coreboot-2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7.tar.bz2
coreboot-2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7.zip
soc/intel/elkhartlake: Fix PMC read_resources callback
The `limit` field for the PMC fixed BAR was incorrectly set to the `base + size + 1`, where it should be `base + size - 1`, to correctly tell the allocator the limit. Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Change-Id: Ib2d8c7ffe87fdd970f3172bb4e6b2c9386859ab3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65460 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Werner Zeh <werner.zeh@siemens.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/elkhartlake/pmc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/elkhartlake/pmc.c b/src/soc/intel/elkhartlake/pmc.c
index 223e17070fae..e556ac81f81e 100644
--- a/src/soc/intel/elkhartlake/pmc.c
+++ b/src/soc/intel/elkhartlake/pmc.c
@@ -76,7 +76,7 @@ static void soc_pmc_read_resources(struct device *dev)
res = new_resource(dev, 1);
res->base = (resource_t)ACPI_BASE_ADDRESS;
res->size = (resource_t)ACPI_BASE_SIZE;
- res->limit = res->base + res->size + 1;
+ res->limit = res->base + res->size - 1;
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}