summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-10-12 19:07:15 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-10-13 23:59:15 +0000
commita5f11ebdd70eb4d05a309c02eebebd342897acea (patch)
tree922dfe5adade8737582a8c69c87b9487de28ed45 /src
parentb68e22409d8e22e097193bd26cb31213c7030db7 (diff)
downloadcoreboot-a5f11ebdd70eb4d05a309c02eebebd342897acea.tar.gz
coreboot-a5f11ebdd70eb4d05a309c02eebebd342897acea.tar.bz2
coreboot-a5f11ebdd70eb4d05a309c02eebebd342897acea.zip
mb/amd,google/*/devicetree: drop CPU cluster device for Stoneyridge
Since commit 60e9114c6210 ("include/device: ensure valid link/bus is passed to mp_cpu_bus_init"), no dummy LAPIC device is required under the CPU cluster device. Since the CPU cluster device is already present in the Stoneyridge chipset devicetree, drop the whole CPU cluster part from the mainboard's devicetrees. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I8918c14be25ac9756926a9c6a2806a3dceced42a Reviewed-on: https://review.coreboot.org/c/coreboot/+/68317 Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/amd/gardenia/devicetree.cb3
-rw-r--r--src/mainboard/amd/padmelon/devicetree.cb4
-rw-r--r--src/mainboard/google/kahlee/variants/aleena/devicetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/careena/devicetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/grunt/devicetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/liara/devicetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/nuwani/devicetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/treeya/devicetree.cb3
8 files changed, 0 insertions, 25 deletions
diff --git a/src/mainboard/amd/gardenia/devicetree.cb b/src/mainboard/amd/gardenia/devicetree.cb
index bb90ed43e23b..23b1377f7304 100644
--- a/src/mainboard/amd/gardenia/devicetree.cb
+++ b/src/mainboard/amd/gardenia/devicetree.cb
@@ -7,9 +7,6 @@ chip soc/amd/stoneyridge
{ {0xA2, 0x00} }, // socket 0 - Channel 0, slots 0 & 1
}"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
subsystemid 0x1022 0x1410 inherit
device pci 0.0 on end # Root Complex
diff --git a/src/mainboard/amd/padmelon/devicetree.cb b/src/mainboard/amd/padmelon/devicetree.cb
index 9b3ddd7649e2..d1f35962b958 100644
--- a/src/mainboard/amd/padmelon/devicetree.cb
+++ b/src/mainboard/amd/padmelon/devicetree.cb
@@ -3,10 +3,6 @@
chip soc/amd/stoneyridge
register "uma_mode" = "UMAMODE_AUTO_LEGACY"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
-
device domain 0 on
subsystemid 0x1022 0x1410 inherit
device pci 0.0 on end # Root Complex
diff --git a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
index 9d49a6573e42..2bf00ba0f228 100644
--- a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
@@ -44,9 +44,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index 4ace016c5d11..c68fcf5c57f9 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -44,9 +44,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 29bbf3ea994d..15e40abe6217 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -44,9 +44,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)
diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
index 3c73341e85a7..fe70ed57b378 100644
--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
@@ -43,9 +43,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)
diff --git a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb
index db77bd5c78e3..ae2379cb1e93 100644
--- a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb
@@ -47,9 +47,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)
diff --git a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb
index b39efb846869..569831c09ad7 100644
--- a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb
@@ -47,9 +47,6 @@ chip soc/amd/stoneyridge
register "i2c_scl_reset" = "GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
GPIO_I2C2_SCL | GPIO_I2C3_SCL"
- device cpu_cluster 0 on
- device lapic 10 on end
- end
device domain 0 on
device pci 0.0 on end # Root Complex
device pci 0.2 off end # IOMMU (Disabled for performance and battery)