diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2022-01-08 12:41:51 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-01-11 14:01:16 +0000 |
| commit | a6bc494e234a9325016696fd9692d84b838c059f (patch) | |
| tree | 73d9570481eae636c60bbf08dd3692d4d81cedab /src | |
| parent | 9a91ed337099213fea9b0a7636efac130dc0cf82 (diff) | |
| download | coreboot-a6bc494e234a9325016696fd9692d84b838c059f.tar.gz coreboot-a6bc494e234a9325016696fd9692d84b838c059f.tar.bz2 coreboot-a6bc494e234a9325016696fd9692d84b838c059f.zip | |
mb/google/brya: Restructure PMC descriptor update
Restructure the code in the `configure_pmc_descriptor()` so that it
matches the code for the `intel/adlrvp` mainboard. This change does
not reindent the contents of the original if-block intentionally as
this will be taken care of in a reproducible follow-up.
Change-Id: I8c9d9087cb2d0668f6a4afbb566d830bb9febd89
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60937
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Sheng Lean Tan <sheng.tan@9elements.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/google/brya/bootblock.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/mainboard/google/brya/bootblock.c b/src/mainboard/google/brya/bootblock.c index d391cd1de58f..d293c5855de5 100644 --- a/src/mainboard/google/brya/bootblock.c +++ b/src/mainboard/google/brya/bootblock.c @@ -29,7 +29,12 @@ static void configure_pmc_descriptor(void) return; } - if (si_desc_buf[PMC_DESC_7_BYTE3] == 0x40) { + if (si_desc_buf[PMC_DESC_7_BYTE3] != 0x40) { + printk(BIOS_DEBUG, "Update of PMC Descriptor is not required!\n"); + return; + } + + { si_desc_buf[PMC_DESC_7_BYTE3] = 0x44; if (rdev_eraseat(&desc_rdev, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) { @@ -49,8 +54,6 @@ static void configure_pmc_descriptor(void) do_full_reset(); die("Failed to trigger GLOBAL RESET\n"); } - - printk(BIOS_DEBUG, "Update of PMC Descriptor is not required!\n"); } void bootblock_mainboard_early_init(void) |