summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2023-03-19 08:01:53 +0100
committerElyes Haouas <ehaouas@noos.fr>2023-04-08 03:36:07 +0000
commitaf93336da378fed9b2f15734518a1ca05c7769b7 (patch)
tree93a038e887e7f4632ffdcfbca38db8980548b59b /src
parentc46242f904b64daee36e6d478e1d88c623fb3c44 (diff)
downloadcoreboot-af93336da378fed9b2f15734518a1ca05c7769b7.tar.gz
coreboot-af93336da378fed9b2f15734518a1ca05c7769b7.tar.bz2
coreboot-af93336da378fed9b2f15734518a1ca05c7769b7.zip
ec/lenovo/pmh7/chip.h: Use 'bool' instead of 'int'
This to fix following error using Clang-16.0.0: /cb-build/coreboot-toolchain.0/clang/LENOVO_W500/mainboard/lenovo/t400/static.c:135:22: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] .backlight_enable = 0x01, ^~~~ /cb-build/coreboot-toolchain.0/clang/LENOVO_W500/mainboard/lenovo/t400/static.c:136:23: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] .dock_event_enable = 0x01, ^~~~ Change-Id: Icd35224877fee355e1bbb8a8e838cb047604babb Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73810 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src')
-rw-r--r--src/ec/lenovo/pmh7/chip.h6
-rw-r--r--src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/haswell/variants/w541/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/l520/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t400/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t410/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t420/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t420s/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t430/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t430s/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t520/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t530/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/t60/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/x200/devicetree.cb2
-rw-r--r--src/mainboard/lenovo/x200/variants/x200/overridetree.cb2
-rw-r--r--src/mainboard/lenovo/x201/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/x220/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/x230/devicetree.cb4
-rw-r--r--src/mainboard/lenovo/x60/devicetree.cb4
20 files changed, 40 insertions, 38 deletions
diff --git a/src/ec/lenovo/pmh7/chip.h b/src/ec/lenovo/pmh7/chip.h
index 1302139fe21a..896578f1bf19 100644
--- a/src/ec/lenovo/pmh7/chip.h
+++ b/src/ec/lenovo/pmh7/chip.h
@@ -3,9 +3,11 @@
#ifndef EC_LENOVO_PMH7_CHIP_H
#define EC_LENOVO_PMH7_CHIP_H
+#include <stdbool.h>
+
struct ec_lenovo_pmh7_config {
- int backlight_enable:1;
- int dock_event_enable:1;
+ bool backlight_enable;
+ bool dock_event_enable;
};
#endif /* EC_LENOVO_PMH7_CHIP_H */
diff --git a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
index fb05027d100b..f8467c7edcaf 100644
--- a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
+++ b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
@@ -55,8 +55,8 @@ chip northbridge/intel/haswell
device pci 1d.0 on end # USB2 EHCI #1
device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb b/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
index 292a30df604d..0d705fb9bd71 100644
--- a/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
+++ b/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
@@ -54,8 +54,8 @@ chip northbridge/intel/haswell
device pci 1d.0 on end # USB2 EHCI #1
device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy
end
chip ec/lenovo/h8 # FIXME: has_power_management_beeps, has_uwb
diff --git a/src/mainboard/lenovo/l520/devicetree.cb b/src/mainboard/lenovo/l520/devicetree.cb
index a01274180058..dd431dfda496 100644
--- a/src/mainboard/lenovo/l520/devicetree.cb
+++ b/src/mainboard/lenovo/l520/devicetree.cb
@@ -54,8 +54,8 @@ chip northbridge/intel/sandybridge
device ref pci_bridge off end # PCI bridge
device ref lpc on # LPC bridge PCI-LPC bridge
chip ec/lenovo/pmh7
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/t400/devicetree.cb b/src/mainboard/lenovo/t400/devicetree.cb
index 1df350ab67bf..259c3e1b2129 100644
--- a/src/mainboard/lenovo/t400/devicetree.cb
+++ b/src/mainboard/lenovo/t400/devicetree.cb
@@ -120,8 +120,8 @@ chip northbridge/intel/gm45
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb
index 200cabbb9263..8d4ab5f6334b 100644
--- a/src/mainboard/lenovo/t410/devicetree.cb
+++ b/src/mainboard/lenovo/t410/devicetree.cb
@@ -99,8 +99,8 @@ chip northbridge/intel/ironlake
end
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip ec/lenovo/h8
device pnp ff.2 on # dummy
diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb
index 33070ebb746d..953044a5d294 100644
--- a/src/mainboard/lenovo/t420/devicetree.cb
+++ b/src/mainboard/lenovo/t420/devicetree.cb
@@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb
index b5576b2bf015..fc3b12c1dd0a 100644
--- a/src/mainboard/lenovo/t420s/devicetree.cb
+++ b/src/mainboard/lenovo/t420s/devicetree.cb
@@ -75,8 +75,8 @@ chip northbridge/intel/sandybridge
device ref lpc on
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb
index 7e54383aa49c..35c23b82c88b 100644
--- a/src/mainboard/lenovo/t430/devicetree.cb
+++ b/src/mainboard/lenovo/t430/devicetree.cb
@@ -64,8 +64,8 @@ chip northbridge/intel/sandybridge
device ref pci_bridge off end # PCI bridge
device ref lpc on # LPC bridge PCI-LPC bridge
chip ec/lenovo/pmh7
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
device pnp ff.1 on end # dummy
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb
index 175a5c84eee2..23a41d6eb557 100644
--- a/src/mainboard/lenovo/t430s/devicetree.cb
+++ b/src/mainboard/lenovo/t430s/devicetree.cb
@@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb
index 7ef12ba2ac21..3cb18b478903 100644
--- a/src/mainboard/lenovo/t520/devicetree.cb
+++ b/src/mainboard/lenovo/t520/devicetree.cb
@@ -73,8 +73,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb
index d47acda2e7b3..becc3575dbb4 100644
--- a/src/mainboard/lenovo/t530/devicetree.cb
+++ b/src/mainboard/lenovo/t530/devicetree.cb
@@ -78,8 +78,8 @@ chip northbridge/intel/sandybridge
device ref lpc on # PCI-LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb
index f72b2e90cd79..25782e97e06b 100644
--- a/src/mainboard/lenovo/t60/devicetree.cb
+++ b/src/mainboard/lenovo/t60/devicetree.cb
@@ -109,8 +109,8 @@ chip northbridge/intel/i945
subsystemid 0x17aa 0x2009
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip ec/lenovo/h8
device pnp ff.2 on # dummy
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
index 704a4102516e..a4232460519b 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
+++ b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
@@ -77,8 +77,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/x200/devicetree.cb b/src/mainboard/lenovo/x200/devicetree.cb
index 6ddd0905a845..7871cfd00d09 100644
--- a/src/mainboard/lenovo/x200/devicetree.cb
+++ b/src/mainboard/lenovo/x200/devicetree.cb
@@ -110,7 +110,7 @@ chip northbridge/intel/gm45
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
+ register "backlight_enable" = "true"
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/x200/variants/x200/overridetree.cb b/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
index 51beecc89726..cd69e2eba438 100644
--- a/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
+++ b/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
@@ -17,7 +17,7 @@ chip northbridge/intel/gm45
device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "dock_event_enable" = "0x01"
+ register "dock_event_enable" = "true"
end
chip superio/nsc/pc87382
device pnp 164e.3 on # Digitizer
diff --git a/src/mainboard/lenovo/x201/devicetree.cb b/src/mainboard/lenovo/x201/devicetree.cb
index fc7c4700911d..6c27f53d7786 100644
--- a/src/mainboard/lenovo/x201/devicetree.cb
+++ b/src/mainboard/lenovo/x201/devicetree.cb
@@ -106,8 +106,8 @@ chip northbridge/intel/ironlake
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip ec/lenovo/h8
diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb
index eb79baaed206..7a9959931e40 100644
--- a/src/mainboard/lenovo/x220/devicetree.cb
+++ b/src/mainboard/lenovo/x220/devicetree.cb
@@ -78,8 +78,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb
index 490f837197f3..fdd5059e6a81 100644
--- a/src/mainboard/lenovo/x230/devicetree.cb
+++ b/src/mainboard/lenovo/x230/devicetree.cb
@@ -80,8 +80,8 @@ chip northbridge/intel/sandybridge
device ref lpc on #LPC bridge
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip drivers/pc80/tpm
diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb
index f63acf73250e..0e1e5fced5ac 100644
--- a/src/mainboard/lenovo/x60/devicetree.cb
+++ b/src/mainboard/lenovo/x60/devicetree.cb
@@ -97,8 +97,8 @@ chip northbridge/intel/i945
subsystemid 0x17aa 0x2009
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
- register "backlight_enable" = "0x01"
- register "dock_event_enable" = "0x01"
+ register "backlight_enable" = "true"
+ register "dock_event_enable" = "true"
end
chip ec/lenovo/h8
device pnp ff.2 on # dummy