summaryrefslogtreecommitdiffstats
path: root/util/cbfstool/cbfs-mkstage.c
diff options
context:
space:
mode:
authorHung-Te Lin <hungte@chromium.org>2013-01-28 15:53:34 +0800
committerHung-Te Lin <hungte@chromium.org>2013-02-01 06:50:17 +0100
commit332795cc5951c6d65badd2bbf3c79f6b63dbdbc2 (patch)
treeb6e6d44b49e53b2cf1c99fb80db5e6b20043c340 /util/cbfstool/cbfs-mkstage.c
parentd723c5b554786794217a92acb4ce0096bf924da8 (diff)
downloadcoreboot-332795cc5951c6d65badd2bbf3c79f6b63dbdbc2.tar.gz
coreboot-332795cc5951c6d65badd2bbf3c79f6b63dbdbc2.tar.bz2
coreboot-332795cc5951c6d65badd2bbf3c79f6b63dbdbc2.zip
cbfstool: Make endian detection functions to work without prior setup.
The 'host_bigendian' variable (and functions relying on it like ntohl/htonl) requires host detection by calling static which_endian() first -- which may be easily forgotten by developers. It's now a public function in common.c and doesn't need initialization anymore. Change-Id: I13dabd1ad15d2d6657137d29138e0878040cb205 Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: http://review.coreboot.org/2199 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'util/cbfstool/cbfs-mkstage.c')
-rw-r--r--util/cbfstool/cbfs-mkstage.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/cbfstool/cbfs-mkstage.c b/util/cbfstool/cbfs-mkstage.c
index ef5182aae3e8..4374bdadf571 100644
--- a/util/cbfstool/cbfs-mkstage.c
+++ b/util/cbfstool/cbfs-mkstage.c
@@ -77,7 +77,7 @@ int parse_elf_to_stage(unsigned char *input, unsigned char **output,
if (ehdr->e_ident[EI_DATA] == ELFDATA2MSB) {
elf_bigendian = 1;
}
- if (elf_bigendian != host_bigendian) {
+ if (elf_bigendian != is_big_endian()) {
elf32_to_native = swap32;
}