diff options
| author | Jakub Czapiga <jacz@semihalf.com> | 2022-08-01 16:01:28 +0200 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-08-03 23:24:49 +0000 |
| commit | aa41563483ca5a88afc22985a89df05166302cd2 (patch) | |
| tree | 8d00738e58b0d1421da53baa66ea3a69ce662f8e /util/cbfstool/ifittool.c | |
| parent | 77b2d45c9e4374320e802749e144bf40cb4a3f87 (diff) | |
| download | coreboot-aa41563483ca5a88afc22985a89df05166302cd2.tar.gz coreboot-aa41563483ca5a88afc22985a89df05166302cd2.tar.bz2 coreboot-aa41563483ca5a88afc22985a89df05166302cd2.zip | |
util/cbfstool: Fix truncate command error handling and cbfs_image_from_buffer()
Check return value of cbfs_truncate_space() in cbfs_truncate().
Remove return from cbfs_image_from_buffer() to inform about invalid
image region when incorrect offset header was provided.
Also change header offset provided to mentioned function in
cbfs_expand_to_region() and cbfs_truncate_space() from zero
to HEADER_OFFSET_UNKNOWN, as they do not support images with cbfs master
header.
Signed-off-by: Jakub Czapiga <jacz@semihalf.com>
Change-Id: Ib009212692fb3594a826436df765860f54837154
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66334
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'util/cbfstool/ifittool.c')
| -rw-r--r-- | util/cbfstool/ifittool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/cbfstool/ifittool.c b/util/cbfstool/ifittool.c index 88a973c5afc8..9ea3149fcc95 100644 --- a/util/cbfstool/ifittool.c +++ b/util/cbfstool/ifittool.c @@ -146,7 +146,7 @@ int main(int argc, char *argv[]) uint32_t addr = 0; size_t topswap_size = 0; enum fit_type fit_type = 0; - uint32_t headeroffset = ~0u; + uint32_t headeroffset = HEADER_OFFSET_UNKNOWN; verbose = 0; |