diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-11-25 09:53:28 +0100 |
|---|---|---|
| committer | Patrick Georgi <patrick@coreboot.org> | 2021-11-26 10:20:24 +0000 |
| commit | 1a55dbf7e98044040df106e335fdd1eba9212ce5 (patch) | |
| tree | 9427b6e44a607c0cb677053337de4ae0d8a49187 /util/ifdtool/Makefile | |
| parent | d43d171f650e343c68dec0c094586aa3fab2daea (diff) | |
| download | coreboot-1a55dbf7e98044040df106e335fdd1eba9212ce5.tar.gz coreboot-1a55dbf7e98044040df106e335fdd1eba9212ce5.tar.bz2 coreboot-1a55dbf7e98044040df106e335fdd1eba9212ce5.zip | |
util/ifdtool/Makefile: Fix building as standalone tool
Commit f1e401c6cb70 (util/cbfstool/flashmap/fmap.c: fix fmaptool
endianness bugs on BE) makes use of endianness conversion macros
in cbfstool's FMAP code, which is also used by ifdtool. At least
on Linux, the <endian.h> header provides these helpers, but only
when `__USE_MISC` is defined, which is defined in the <ctypes.h>
header when `_DEFAULT_SOURCE` is defined. This was accounted for
in `Makefile.inc`, but not in `Makefile`. As a result, trying to
build ifdtool as a standalone tool (i.e. not as part of building
a coreboot image) results in build errors because the endianness
conversion macros are not defined.
Define `_DEFAULT_SOURCE` in `Makefile` to fix the build errors.
Change-Id: I8c2bbc07ddd87d885e2d6f5c7f2bd501e5c4e3b0
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59663
Reviewed-by: Patrick Georgi <patrick@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util/ifdtool/Makefile')
| -rw-r--r-- | util/ifdtool/Makefile | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index e8d818c021fc..473dc0834804 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -11,6 +11,7 @@ CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror CFLAGS += -I../../src/commonlib/include -I../../src/commonlib/bsd/include CFLAGS += -I../cbfstool/flashmap CFLAGS += -include ../../src/commonlib/bsd/include/commonlib/bsd/compiler.h +CFLAGS += -D_DEFAULT_SOURCE # for endianness converting functions LDFLAGS = OBJS = ifdtool.o |