diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2022-10-21 20:11:10 +0200 |
|---|---|---|
| committer | Lean Sheng Tan <sheng.tan@9elements.com> | 2023-02-02 13:19:36 +0000 |
| commit | be25f96c2d22cf348b0c47f941bea07f497c2bb8 (patch) | |
| tree | 311ce00419ca2e5beebc8d7871c83f1b704c0c7e /util/ifdtool/ifdtool.c | |
| parent | 16598745b8d30d6cddf7f9c59403a2a250124acc (diff) | |
| download | coreboot-be25f96c2d22cf348b0c47f941bea07f497c2bb8.tar.gz coreboot-be25f96c2d22cf348b0c47f941bea07f497c2bb8.tar.bz2 coreboot-be25f96c2d22cf348b0c47f941bea07f497c2bb8.zip | |
ifdtool: Cleanup IFDv1 detection
Change https://review.coreboot.org/c/coreboot/+/54305 "util/ifdtool:
Use -p platform name to detect IFDv2 platform and chipset" made
the '-p' argument mandatory for IFDv2 platforms.
Drop the IFDv2 platform CHIPSET_C620_SERIES_LEWISBURG from IFDv1
detection.
Change-Id: If29f8718b7aa696cdc07deef4c98be9a68c66f10
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68680
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util/ifdtool/ifdtool.c')
| -rw-r--r-- | util/ifdtool/ifdtool.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 1ddb6b7fe194..4048699242ea 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -203,7 +203,6 @@ static enum ich_chipset ifd1_guess_chipset(char *image, int size) uint32_t iccriba = (fdb->flmap2 >> 16) & 0xff; uint32_t msl = (fdb->flmap2 >> 8) & 0xff; uint32_t isl = (fdb->flmap1 >> 24); - uint32_t nm = (fdb->flmap1 >> 8) & 0x7; /* Rest for IFD1 chipset type */ if (iccriba == 0x00) { @@ -226,8 +225,6 @@ static enum ich_chipset ifd1_guess_chipset(char *image, int size) return CHIPSET_8_SERIES_LYNX_POINT; printf("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n"); return CHIPSET_9_SERIES_WILDCAT_POINT; - } else if (nm == 6) { - return CHIPSET_C620_SERIES_LEWISBURG; } return CHIPSET_PCH_UNKNOWN; } |