diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2022-07-29 17:19:48 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-08-01 20:30:39 +0000 |
| commit | 0b4f49c792c21a9a806cc57a5563da4947abc0be (patch) | |
| tree | d633b1da2b1c9d6153c6c5532aee57fb0555431f /util | |
| parent | 84753144d0d96ebe08c21d32c65b2fb8e31a18ba (diff) | |
| download | coreboot-0b4f49c792c21a9a806cc57a5563da4947abc0be.tar.gz coreboot-0b4f49c792c21a9a806cc57a5563da4947abc0be.tar.bz2 coreboot-0b4f49c792c21a9a806cc57a5563da4947abc0be.zip | |
util/spd_tools/spd_gen/lp5: Remove maxSpeed for Sabrina
Firmware component that does memory training already limits the memory
controller to train at 5500 Mbps for all memory parts in Sabrina. Hence
removing this interim SPD change to limit the speed.
BUG=b:238074863
TEST=Build and boot to OS in Skyrim.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Change-Id: I2bc82c7407a97aac282708c3e0bd56ae99a8fc31
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66290
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/spd_tools/src/spd_gen/lp5.go | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index 64fb53fbe281..09387c740b54 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -70,7 +70,6 @@ type LP5Set struct { otherOptionalFeatures byte busWidthEncoding byte speedToTCKMinPs map[int]int - maxSpeedMbps int } /* ------------------------------------------------------------------------------------------ */ @@ -235,8 +234,6 @@ var LP5SetInfo = map[int]LP5Set{ * Set to 0x02. */ busWidthEncoding: 0x02, - /* Sabrina supports max speed of 5500 MT/s */ - maxSpeedMbps: 5500, }, } @@ -640,14 +637,6 @@ func LP5EncodeTRFCPBMinLsb(memAttribs *LP5MemAttributes) byte { return byte(convNsToMtb(memAttribs.TRFCPBNs) & 0xff) } -func LP5UpdateSpeedMbps(memAttribs *LP5MemAttributes) { - f, ok := LP5SetInfo[LP5CurrSet] - - if ok && f.maxSpeedMbps != 0 && memAttribs.SpeedMbps > f.maxSpeedMbps { - memAttribs.SpeedMbps = f.maxSpeedMbps - } -} - func LP5UpdateTCKMin(memAttribs *LP5MemAttributes) { if memAttribs.TCKMinPs == 0 { memAttribs.TCKMinPs = LP5GetTCKMinPs(memAttribs) @@ -695,7 +684,6 @@ func LP5UpdateTRPPB(memAttribs *LP5MemAttributes) { } func lp5UpdateMemoryAttributes(memAttribs *LP5MemAttributes) { - LP5UpdateSpeedMbps(memAttribs) LP5UpdateTCKMin(memAttribs) LP5UpdateTAAMin(memAttribs) LP5UpdateTRFCAB(memAttribs) |