diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2022-07-07 16:37:05 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-07-19 15:11:53 +0000 |
| commit | d5ea355c73ab7ea581f55572b3954ac62d9fa1ff (patch) | |
| tree | 8de3a887385f2fd24658d88214f05ec38b9d5458 /util | |
| parent | be8cd6ba61f6c240b543df181a4aa7fe4a4f163b (diff) | |
| download | coreboot-d5ea355c73ab7ea581f55572b3954ac62d9fa1ff.tar.gz coreboot-d5ea355c73ab7ea581f55572b3954ac62d9fa1ff.tar.bz2 coreboot-d5ea355c73ab7ea581f55572b3954ac62d9fa1ff.zip | |
util/spd_tools: Limit memory speed to 5500 Mbps for Sabrina
In Sabrina platform, memory speed is limited to 5500 Mbps. Update the
SPD generation tool to limit to that speed.
BUG=b:238074863
TEST=Build and boot to OS in Skyrim.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Change-Id: Ie3507898167012e0d812c9b1aacba72e9055fcd8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65708
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/spd_tools/src/spd_gen/lp5.go | 22 |
1 files changed, 17 insertions, 5 deletions
diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index 0b3a5adae1c1..64fb53fbe281 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -70,6 +70,7 @@ type LP5Set struct { otherOptionalFeatures byte busWidthEncoding byte speedToTCKMinPs map[int]int + maxSpeedMbps int } /* ------------------------------------------------------------------------------------------ */ @@ -194,7 +195,7 @@ var LP5SetInfo = map[int]LP5Set{ * 2:0 (Bus width) = 001 (x16 always) * Set to 0x01. */ - busWidthEncoding: 0x01, + busWidthEncoding: 0x01, /* * TCKMinPs: * LPDDR5 has two clocks: the command/address clock (CK) and the data clock (WCK). They are @@ -208,7 +209,7 @@ var LP5SetInfo = map[int]LP5Set{ 7500 : 1066, /* 1 / (7500 / 2 / 4) */ 6400 : 1250, /* 1 / (6400 / 2 / 4) */ 5500 : 1455, /* 1 / (5500 / 2 / 4) */ - }, + }, }, 1: { SPDRevision: LP5SPDValueRevision1_1, @@ -219,13 +220,13 @@ var LP5SetInfo = map[int]LP5Set{ * 3:0 (Maximum Activate Count) = 1000 (Unlimited MAC) * Set to 0x18. */ - optionalFeatures: 0x18, + optionalFeatures: 0x18, /* * For Sabrina (as per advisory b/211510456): * 7:6 (PPR) = 1 (Post Package Repair is supported) * Set to 0x40. */ - otherOptionalFeatures: 0x40, + otherOptionalFeatures: 0x40, /* * For Sabrina (as per advisory b/211510456): * 7:5 (Number of system channels) = 000 (1 channel always) @@ -233,7 +234,9 @@ var LP5SetInfo = map[int]LP5Set{ * 2:0 (Bus width) = 010 (x32 always) * Set to 0x02. */ - busWidthEncoding: 0x02, + busWidthEncoding: 0x02, + /* Sabrina supports max speed of 5500 MT/s */ + maxSpeedMbps: 5500, }, } @@ -637,6 +640,14 @@ func LP5EncodeTRFCPBMinLsb(memAttribs *LP5MemAttributes) byte { return byte(convNsToMtb(memAttribs.TRFCPBNs) & 0xff) } +func LP5UpdateSpeedMbps(memAttribs *LP5MemAttributes) { + f, ok := LP5SetInfo[LP5CurrSet] + + if ok && f.maxSpeedMbps != 0 && memAttribs.SpeedMbps > f.maxSpeedMbps { + memAttribs.SpeedMbps = f.maxSpeedMbps + } +} + func LP5UpdateTCKMin(memAttribs *LP5MemAttributes) { if memAttribs.TCKMinPs == 0 { memAttribs.TCKMinPs = LP5GetTCKMinPs(memAttribs) @@ -684,6 +695,7 @@ func LP5UpdateTRPPB(memAttribs *LP5MemAttributes) { } func lp5UpdateMemoryAttributes(memAttribs *LP5MemAttributes) { + LP5UpdateSpeedMbps(memAttribs) LP5UpdateTCKMin(memAttribs) LP5UpdateTAAMin(memAttribs) LP5UpdateTRFCAB(memAttribs) |