diff options
author | Laszlo Ersek <lersek@redhat.com> | 2017-05-18 14:48:13 +0200 |
---|---|---|
committer | Laszlo Ersek <lersek@redhat.com> | 2017-05-18 23:38:45 +0200 |
commit | 1ee0e6532fb1f863b48c169dbc42a71d0097c5c8 (patch) | |
tree | 36a06ffa21801fa8f0ca2fe6f4693e062c4d2d02 | |
parent | ce69cc776cfcc4a0869907cd4263fd134064dbaf (diff) | |
download | edk2-1ee0e6532fb1f863b48c169dbc42a71d0097c5c8.tar.gz edk2-1ee0e6532fb1f863b48c169dbc42a71d0097c5c8.tar.bz2 edk2-1ee0e6532fb1f863b48c169dbc42a71d0097c5c8.zip |
EmulatorPkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()
According to the PI spec, Volume 3,
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks():
> The variable argument list is a list of tuples. Each tuple describes a
> range of LBAs to erase and consists of the following:
> * An EFI_LBA that indicates the starting LBA
> * A UINTN that indicates the number of blocks to erase
(NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.)
In this driver, the NumOfLba local variable is defined with type UINTN,
but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch.
Cc: Andrew Fish <afish@apple.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Reported-by: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
-rw-r--r-- | EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c b/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c index 44df1172b1..fdffca2c94 100644 --- a/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c +++ b/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c @@ -906,7 +906,7 @@ Returns: break;
}
- NumOfLba = VA_ARG (args, UINT32);
+ NumOfLba = VA_ARG (args, UINTN);
//
// Check input parameters
@@ -926,7 +926,7 @@ Returns: break;
}
- NumOfLba = VA_ARG (args, UINT32);
+ NumOfLba = VA_ARG (args, UINTN);
while (NumOfLba > 0) {
Status = FvbEraseBlock (FvbDevice->Instance, StartingLba, mFvbModuleGlobal, EfiGoneVirtual ());
|