diff options
| author | Star Zeng <star.zeng@intel.com> | 2018-02-14 17:10:36 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2018-05-10 14:23:51 +0800 |
| commit | f8c8e99c9e212f1be0be5c28a432a369a1e30348 (patch) | |
| tree | e0b590d0f2402ef8ffaebec37062ac2adf0040b0 | |
| parent | 7ebe491ca6ade15158eea7a5ed47214c6c122b29 (diff) | |
| download | edk2-f8c8e99c9e212f1be0be5c28a432a369a1e30348.tar.gz edk2-f8c8e99c9e212f1be0be5c28a432a369a1e30348.tar.bz2 edk2-f8c8e99c9e212f1be0be5c28a432a369a1e30348.zip | |
IntelSiliconPkg VTdPmrPei: Return SUCCESS when Mapping == NULL in Unmap
NULL is returned to Mapping when Operation is BusMasterCommonBuffer or
BusMasterCommonBuffer64 in PeiIoMmuMap().
So Mapping == NULL is valid when calling PeiIoMmuUnmap().
940dbd071e9f01717236af236740aa0da716805f wrongly changed EFI_SUCCESS
to EFI_INVALID_PARAMETER when Mapping == NULL in PeiIoMmuUnmap().
This patch is to correct it.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
(cherry picked from commit abe63fa7dc0de3e1875139a4abd62357795f52d7)
| -rw-r--r-- | IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c b/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c index c6a1ccdb1b..2b2df1f425 100644 --- a/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c @@ -189,7 +189,7 @@ PeiIoMmuMap ( if (Operation == EdkiiIoMmuOperationBusMasterCommonBuffer ||
Operation == EdkiiIoMmuOperationBusMasterCommonBuffer64) {
*DeviceAddress = (UINTN)HostAddress;
- *Mapping = 0;
+ *Mapping = NULL;
return EFI_SUCCESS;
}
@@ -266,7 +266,7 @@ PeiIoMmuUnmap ( }
if (Mapping == NULL) {
- return EFI_INVALID_PARAMETER;
+ return EFI_SUCCESS;
}
MapInfo = Mapping;
|