summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRanbir Singh <Ranbir.Singh3@Dell.com>2023-07-17 19:40:08 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2023-09-20 06:49:52 +0000
commit4317b4824bc881fe6079d04b7ee5b0f6bddf62ca (patch)
tree02f30abe956aee3ac14a922a88d60066b98b5b9d
parent4fb69c2bee3006b08ca2abba58843f7573e0c5c6 (diff)
downloadedk2-4317b4824bc881fe6079d04b7ee5b0f6bddf62ca.tar.gz
edk2-4317b4824bc881fe6079d04b7ee5b0f6bddf62ca.tar.bz2
edk2-4317b4824bc881fe6079d04b7ee5b0f6bddf62ca.zip
MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue
The code can reach line 65 only through the else path above at line 53. The else path already has the same NULL check at line 55 and hence the duplicate code lines are totally redundant which can be deleted. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220 Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
-rw-r--r--MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
index d704c62eaa..1d03d49640 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
@@ -62,10 +62,6 @@ NvmeS3SkipThisController (
}
}
- if (S3InitDevices == NULL) {
- return Skip;
- }
-
//
// Only need to initialize the controllers that exist in the device list.
//