summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGang Chen <gang.c.chen@intel.com>2024-01-08 09:52:51 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2024-01-10 01:43:54 +0000
commitedba0779ba05c0598dbdd32006714fed4fd24ae0 (patch)
tree9201f91446c4b28e67ccd8fe0947b8e1250e9cde
parent4a443f73fd67ca8caaf0a3e1a01f8231b330d2e0 (diff)
downloadedk2-edba0779ba05c0598dbdd32006714fed4fd24ae0.tar.gz
edk2-edba0779ba05c0598dbdd32006714fed4fd24ae0.tar.bz2
edk2-edba0779ba05c0598dbdd32006714fed4fd24ae0.zip
UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check
It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Reviewed-by: James Lu <james.lu@intel.com> Reviewed-by: Gua Guo <gua.guo@intel.com> Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
-rw-r--r--UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c38
1 files changed, 0 insertions, 38 deletions
diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
index 1b9208b6d3..748728981a 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
@@ -134,44 +134,6 @@ Done:
ASSERT (Fadt->Pm1aEvtBlk != 0);
ASSERT (Fadt->Gpe0Blk != 0);
- DEBUG_CODE_BEGIN ();
- BOOLEAN SciEnabled;
-
- //
- // Check the consistency of SCI enabling
- //
-
- //
- // Get SCI_EN value
- //
- if (Fadt->Pm1CntLen == 4) {
- SciEnabled = (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;
- } else {
- //
- // if (Pm1CntLen == 2), use 16 bit IO read;
- // if (Pm1CntLen != 2 && Pm1CntLen != 4), use 16 bit IO read as a fallback
- //
- SciEnabled = (IoRead16 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;
- }
-
- if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) &&
- (Fadt->SmiCmd == 0) &&
- !SciEnabled)
- {
- //
- // The ACPI enabling status is inconsistent: SCI is not enabled but ACPI
- // table does not provide a means to enable it through FADT->SmiCmd
- //
- DEBUG ((
- DEBUG_ERROR,
- "ERROR: The ACPI enabling status is inconsistent: SCI is not"
- " enabled but the ACPI table does not provide a means to enable it through FADT->SmiCmd."
- " This may cause issues in OS.\n"
- ));
- }
-
- DEBUG_CODE_END ();
-
return RETURN_SUCCESS;
}